Skip to content

ci: define package name as secret for deployment #38

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
2sem merged 1 commit into from
Feb 5, 2026
Merged

ci: define package name as secret for deployment #38

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 1 addition & 3 deletions .github/workflows/deploy-ios.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,6 +24,7 @@ jobs:
runs-on: macos-26
env:
PRODUCT_NAME: 'talktrans'
PACKAGE_NAME: ${{ secrets.PACKAGE_NAME }}
IOS_CERT_PATH: 'cert.p12'
IOS_PROFILE_PATH: 'profile.mobileprovision'
IOS_KEY_PATH: 'api-key.json'
Expand Down Expand Up @@ -100,7 +101,6 @@ jobs:

- name: Setup Certificates and Increment Version
env:
PACKAGE_NAME: 'com.credif.talktrans'
APPLE_TEAM_ID: ${{ secrets.APPLE_TEAM_ID }}
IOS_CERT_PWD: ${{ secrets.IOS_CERT_P12_PWD }}
IOS_KEYCHAIN: ${{ secrets.IOS_KEYCHAIN }}
Expand All @@ -111,7 +111,6 @@ jobs:
- name: Create export options plist
env:
TEAM_ID: ${{ secrets.APPLE_TEAM_ID }}
PACKAGE_NAME: 'com.credif.talktrans'
run: |
cat > ./exportOptions.plist <<EOF
<?xml version="1.0" encoding="UTF-8"?>
Expand Down Expand Up @@ -173,7 +172,6 @@ jobs:

- name: Upload to TestFlight/App Store
env:
PACKAGE_NAME: 'com.credif.talktrans'
IOS_IPA_PATH: ./Output/IPA/App.ipa
run: |
fastlane ios upload description:'${{ github.event.inputs.body }}' isReleasing:${{ github.event.inputs.isReleasing }}
Loading