Skip to content

fix: preserve Chinese locale scripts#107

Merged
2sem merged 1 commit into
mainfrom
fix/korean-chinese-support
Apr 4, 2026
Merged

fix: preserve Chinese locale scripts#107
2sem merged 1 commit into
mainfrom
fix/korean-chinese-support

Conversation

@2sem

@2sem 2sem commented Apr 4, 2026

Copy link
Copy Markdown
Owner

Summary

  • Fix locale mapping so Chinese script variants are preserved instead of collapsing to plain zh during translation support checks.
  • Restore Korean → Chinese and Korean → Traditional Chinese support by routing locale matching through TranslationLocale.from(locale:).

Test Status

  • Environment review confirmed the root cause and patch path.
  • Full mise x -- tuist ... verification is blocked here by missing tuist auth login.

Flow

flowchart TD
    A[User selects Korean source] --> B[User selects Chinese target]
    B --> C[Locale mapping keeps Hans/Hant script]
    C --> D[Supported pair resolves correctly]
    D --> E[Translation can proceed]
Loading

@tuist

tuist Bot commented Apr 4, 2026

Copy link
Copy Markdown

🛠️ Tuist Run Report 🛠️

Tests 🧪

Scheme Status Cache hit rate Tests Skipped Ran Commit
talktrans-Workspace 0 % 1 0 1 207c0c790

Builds 🔨

Scheme Status Duration Commit
talktrans-Workspace 1m 36s 207c0c790

@2sem 2sem merged commit 791bcd9 into main Apr 4, 2026
1 check passed
@2sem 2sem deleted the fix/korean-chinese-support branch April 4, 2026 11:17
@2sem 2sem mentioned this pull request Apr 4, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant