Skip to content

chore: interface{}→any in conformance harness; ignore tracker CLI binary#495

Open
clintecker wants to merge 1 commit into
mainfrom
chore/conformance-any-gitignore
Open

chore: interface{}→any in conformance harness; ignore tracker CLI binary#495
clintecker wants to merge 1 commit into
mainfrom
chore/conformance-any-gitignore

Conversation

@clintecker

@clintecker clintecker commented Jul 22, 2026

Copy link
Copy Markdown
Collaborator

Small repo-hygiene follow-up to #455.

Changes

Verification

  • go build ./cmd/tracker-conformance/ passes
  • pre-commit hooks green (coverage, complexity, tests, lint, format)

🤖 Generated with Claude Code


View with Codesmith Autofix with Codesmith
Need help on this PR? Tag /codesmith with what you need. Autofix is disabled.

Summary by CodeRabbit

  • Chores
    • Updated project ignore rules to exclude generated tracker executables.
    • Modernized internal JSON handling without changing user-visible behavior.

- cmd/tracker-conformance/main.go: modernize interface{} to the any alias
  (consistent with the #455 hygiene sweep)
- .gitignore: exclude the compiled /cmd/tracker/tracker binary, matching
  the existing /cmd/trackerbot/trackerbot entry

Co-Authored-By: Claude Opus 4.8 <[email protected]>
Claude-Session: https://claude.ai/code/session_01GVTTPqhd6w2tzmgwEqJpL3
@coderabbitai

coderabbitai Bot commented Jul 22, 2026

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 827ac1b0-2eae-473d-95bd-73645f4e3583

📥 Commits

Reviewing files that changed from the base of the PR and between 57ce823 and 5058113.

📒 Files selected for processing (2)
  • .gitignore
  • cmd/tracker-conformance/main.go

Walkthrough

The conformance CLI replaces interface{} JSON plumbing with Go’s any type across formatters, handlers, decoding, and output. .gitignore also excludes two command binaries.

Changes

Conformance CLI JSON types

Layer / File(s) Summary
JSON payload type migration
cmd/tracker-conformance/main.go
JSON maps, decoding targets, diagnostics, and writeJSON now use any-based types without changing control flow or output behavior.

Generated binary ignore rules

Layer / File(s) Summary
Tracker binary ignore rules
.gitignore
Adds ignore patterns for the trackerbot and tracker executables.

Estimated code review effort: 2 (Simple) | ~10 minutes

Suggested reviewers: harperreed

Poem

I’m a rabbit with a tidy JSON nest,
any hops in where old types rest.
Two little binaries vanish from sight,
Ignored by Git through the quiet night.
Carrots all round—the diff is light!

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title accurately summarizes both changes: the any type refactor and ignoring the tracker CLI binary.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch chore/conformance-any-gitignore

Comment @coderabbitai help to get the list of available commands.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant