docs: tidy diagram labels, linter table, and remaining nits (Batch 5)#61
Conversation
…(Batch 5) Batch 5 (final) of the documentation-accuracy audit (#56). - F15: SceneGeometryAndLinting linter table omitted three checks the linter emits — added edge-endpoint-detached (error), edges-doubled (error), edge-under-label (warning), from DiagramScene.swift. - F19: android/README pipeline diagram showed SceneRenderer.draw(canvas); the real Kotlin signature is draw(scene, canvas). - F22: performance.md called flowchart the *only* super-linear layout and maxEdges flowchart-specific; swimlane shares the same network-simplex layered layout, and maxEdges is a shared parse-level cap. - F23: README terminal ladder called the most-portable tier "plain ASCII"; it is monochrome Unicode box-drawing. - F24: AddingADiagramType framed venn as a hypothetical "venn-beta"; venn is a real shipped type — reframed as a worked example with finished files to read. - F26: pi-canvas "No core changes" contradicted its own "gap it closed" (a Linux rgbaRaster was added to core) — reworded. - F27: dropped the unverified "60fps on a Pi 5" panning figure. Closes #56. Completes the documentation-accuracy audit (tracking #51). Co-Authored-By: Claude Opus 4.8 <[email protected]> Claude-Session: https://claude.ai/code/session_014CJYAapHgDn2PWGNABnFtv
|
Warning Review limit reachedYou’ve reached a temporary PR review limit under our Fair Usage Limits Policy. Next review available in: 13 minutes Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available. How can I continue?After more reviews become available, a review can be triggered using the To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews. How do review limits work?CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability. For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window. Please refer docs for additional details. Review details⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (6)
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: e31530f2af
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| is **super-linear in edge count**, which is why the parse-level `maxEdges` (500) | ||
| cap bounds it. |
There was a problem hiding this comment.
When this sentence includes swimlane in the shared layered-layout path, it reads as though the parse-level MermaidParser.maxEdges cap bounds both flowchart and swimlane. However parseSwimlane builds and returns the diagram without an edges.count guard, while only the flowchart dispatch wraps its parser with edges.count <= maxEdges. A large swimlane source under maxTextSize can still feed more than 500 edges into the super-linear layout, so this understates the remaining performance/input-bound risk.
Useful? React with 👍 / 👎.
1 participant
Batch 5 (final) of the doc-accuracy audit. Closes #56. Each verified against code:
edge-endpoint-detached,edges-doubled,edge-under-label), fromDiagramScene.swift.draw(scene, canvas)(SceneRenderer.kt:36).maxEdgesis a shared parse cap, not flowchart-specific.venn-beta.rgbaRaster) and the unverified "60fps on a Pi 5" figure.Completes the audit (tracking #51). Docs-only.
🤖 Generated with Claude Code
Need help on this PR? Tag
/codesmithwith what you need. Autofix is disabled.