fix(build): add missing await for buildInProduction()#160
Merged
northword merged 1 commit intozotero-plugin-dev:mainfrom Feb 7, 2026
Merged
fix(build): add missing await for buildInProduction()#160northword merged 1 commit intozotero-plugin-dev:mainfrom
northword merged 1 commit intozotero-plugin-dev:mainfrom
Conversation
`buildInProduction()` is an async method that packs the XPI and generates update.json. Without `await`, the build process completes before the XPI file is actually written, resulting in no XPI output in production builds. Co-Authored-By: Claude Opus 4.6 <[email protected]>
commit: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
buildInProduction()is an async method that packs the XPI and generates update.json. Withoutawait, the build process completes before the XPI file is actually written, resulting in no XPI output in production builds.