PnP: Fix watch mode for files required under PnP (#7077)

## What's the problem this PR addresses?

When running under `node --watch`, the PnP hook only reports not-found
virtual modules to the watching process, causing found virtual modules
to not be watched.

Fixes (partially) #6871

## How did you fix it?

Report found modules from the PnP hook to the watching process.

Note that this does not fix watch mode for **`import`ed** modules, which
remains broken for node 18.19+. Given that the ESM loader API hasn't
stabilized I am hesitant to make any changes at this moment.

## Checklist

<!--- Don't worry if you miss something, chores are automatically
tested. -->
<!--- This checklist exists to help you remember doing the chores when
you submit a PR. -->
<!--- Put an `x` in all the boxes that apply. -->
- [x] I have read the [Contributing
Guide](https://yarnpkg.com/advanced/contributing).

<!-- See
https://yarnpkg.com/advanced/contributing#preparing-your-pr-to-be-released
for more details. -->
<!-- Check with `yarn version check` and fix with `yarn version check
-i` -->
- [x] I have set the packages that need to be released for my changes to
be effective.

<!-- The "Testing chores" workflow validates that your PR follows our
guidelines. -->
<!-- If it doesn't pass, click on it to see details as to what your PR
might be missing. -->
- [x] I will check that all automated PR checks pass before the PR gets
reviewed.

---------

Co-authored-by: Maël Nison <[email protected]>

Author: clemyan

.pnp.cjs

@@ -0,0 +1,27 @@
+releases:
+  "@yarnpkg/cli": patch
+  "@yarnpkg/plugin-pnp": patch
+  "@yarnpkg/pnp": patch
+
+declined:
+  - "@yarnpkg/plugin-compat"
+  - "@yarnpkg/plugin-constraints"
+  - "@yarnpkg/plugin-dlx"
+  - "@yarnpkg/plugin-essentials"
+  - "@yarnpkg/plugin-init"
+  - "@yarnpkg/plugin-interactive-tools"
+  - "@yarnpkg/plugin-nm"
+  - "@yarnpkg/plugin-npm-cli"
+  - "@yarnpkg/plugin-pack"
+  - "@yarnpkg/plugin-patch"
+  - "@yarnpkg/plugin-pnpm"
+  - "@yarnpkg/plugin-stage"
+  - "@yarnpkg/plugin-typescript"
+  - "@yarnpkg/plugin-version"
+  - "@yarnpkg/plugin-workspace-tools"
+  - "@yarnpkg/builder"
+  - "@yarnpkg/core"
+  - "@yarnpkg/doctor"
+  - "@yarnpkg/nm"
+  - "@yarnpkg/pnpify"
+  - "@yarnpkg/sdks"

.yarn/versions/c071c1e5.yml

@@ -829,9 +829,10 @@ export function makeApi(runtimeState: RuntimeState, opts: MakeApiOptions): PnpAp
     const qualifiedPath = applyNodeExtensionResolution(unqualifiedPath, candidates, {extensions});
 
     if (qualifiedPath) {
+      nodeUtils.reportRequiredFilesToWatchMode([qualifiedPath]);
       return ppath.normalize(qualifiedPath);
     } else {
-      nodeUtils.reportRequiredFilesToWatchMode(candidates.map(candidate => npath.fromPortablePath(candidate)));
+      nodeUtils.reportRequiredFilesToWatchMode(candidates);
 
       const unqualifiedPathForDisplay = getPathForDisplay(unqualifiedPath);
 

packages/yarnpkg-pnp/sources/hook.js

@@ -1,4 +1,5 @@
-import {NativePath, npath, VirtualFS}   from '@yarnpkg/fslib';
+import type {NativePath, PortablePath}  from '@yarnpkg/fslib';
+import {npath, VirtualFS}               from '@yarnpkg/fslib';
 import fs                               from 'fs';
 import path                             from 'path';
 
@@ -54,9 +55,9 @@ Instead change the require of ${basename} in ${parentPath} to a dynamic import()
 
 // https://github.com/nodejs/node/pull/44366
 // https://github.com/nodejs/node/pull/45348
-export function reportRequiredFilesToWatchMode(files: Array<NativePath>) {
+export function reportRequiredFilesToWatchMode(paths: Array<PortablePath>) {
   if (process.env.WATCH_REPORT_DEPENDENCIES && process.send) {
-    files = files.map(filename => npath.fromPortablePath(VirtualFS.resolveVirtual(npath.toPortablePath(filename))));
+    const files = paths.map(filename => npath.fromPortablePath(VirtualFS.resolveVirtual(filename)));
     if (WATCH_MODE_MESSAGE_USES_ARRAYS) {
       process.send({'watch:require': files});
     } else {