fix: Node 25.7+ EBADF by reading CJS source of zip files (#7070)

Attempts to fix the EBADF encountered due to patching fs by doing the
whole read instead.

I did this to get my own changes past a client (i.e. convincing them it
isn't me that is the issue); I'm not sure this is the right long term
choice.

## What's the problem this PR addresses?

#7065

Can't load zipped CJS modules in Node 25.7+

## How did you fix it?

Return the source of zipped files instead of letting Node read it. I
basically just went off this comment:
nodejs/node#62012 (comment)

I'm not certain this is the most desirable way to do this, and if it is
I'm not sure if there are other places that will need additional fixes.
My knowledge of the codebase makes this an uneasy 'this works for me'
solution. I suspect that if it is a reasonable solution, there may be
some deletion that can be done.

## Checklist

- [x] I have read the [Contributing
Guide](https://yarnpkg.com/advanced/contributing).
- [x] I have set the packages that need to be released for my changes to
be effective.
- [x] I will check that all automated PR checks pass before the PR gets
reviewed.

---------

Co-authored-by: Normal Gaussian <[email protected]>
Co-authored-by: Maël Nison <[email protected]>

Author: 3 people

.pnp.loader.mjs

@@ -0,0 +1,27 @@
+releases:
+  "@yarnpkg/cli": patch
+  "@yarnpkg/plugin-pnp": patch
+  "@yarnpkg/pnp": patch
+
+declined:
+  - "@yarnpkg/plugin-compat"
+  - "@yarnpkg/plugin-constraints"
+  - "@yarnpkg/plugin-dlx"
+  - "@yarnpkg/plugin-essentials"
+  - "@yarnpkg/plugin-init"
+  - "@yarnpkg/plugin-interactive-tools"
+  - "@yarnpkg/plugin-nm"
+  - "@yarnpkg/plugin-npm-cli"
+  - "@yarnpkg/plugin-pack"
+  - "@yarnpkg/plugin-patch"
+  - "@yarnpkg/plugin-pnpm"
+  - "@yarnpkg/plugin-stage"
+  - "@yarnpkg/plugin-typescript"
+  - "@yarnpkg/plugin-version"
+  - "@yarnpkg/plugin-workspace-tools"
+  - "@yarnpkg/builder"
+  - "@yarnpkg/core"
+  - "@yarnpkg/doctor"
+  - "@yarnpkg/nm"
+  - "@yarnpkg/pnpify"
+  - "@yarnpkg/sdks"

.yarn/versions/32e18d27.yml

@@ -1,9 +1,9 @@
-import {VirtualFS, npath}                                                                            from '@yarnpkg/fslib';
-import fs                                                                                            from 'fs';
-import {fileURLToPath, pathToFileURL}                                                                from 'url';
+import {VirtualFS, npath}                                                                                                          from '@yarnpkg/fslib';
+import fs                                                                                                                          from 'fs';
+import {fileURLToPath, pathToFileURL}                                                                                              from 'url';
 
-import {SUPPORTS_IMPORT_ATTRIBUTES, SUPPORTS_IMPORT_ATTRIBUTES_ONLY, WATCH_MODE_MESSAGE_USES_ARRAYS} from '../loaderFlags';
-import * as loaderUtils                                                                              from '../loaderUtils';
+import {HAS_BROKEN_FSTAT_FOR_ZIP_FDS, SUPPORTS_IMPORT_ATTRIBUTES, SUPPORTS_IMPORT_ATTRIBUTES_ONLY, WATCH_MODE_MESSAGE_USES_ARRAYS} from '../loaderFlags';
+import * as loaderUtils                                                                                                            from '../loaderUtils';
 
 // The default `load` doesn't support reading from zip files
 export async function load(
@@ -61,9 +61,14 @@ export async function load(
     });
   }
 
+  const shouldReadSource = format === `commonjs` && HAS_BROKEN_FSTAT_FOR_ZIP_FDS && filePath.includes(`.zip/`);
+  const source = format !== `commonjs` || shouldReadSource
+    ? await fs.promises.readFile(filePath, `utf8`)
+    : undefined;
+
   return {
     format,
-    source: format === `commonjs` ? undefined : await fs.promises.readFile(filePath, `utf8`),
+    source,
     shortCircuit: true,
   };
 }

packages/yarnpkg-pnp/sources/esm-loader/built-loader.js

@@ -20,3 +20,5 @@ export const SUPPORTS_IMPORT_ATTRIBUTES = major >= 21 || (major === 20 && minor
 
 // https://github.com/nodejs/node/pull/52104
 export const SUPPORTS_IMPORT_ATTRIBUTES_ONLY = major >= 22;
+
+export const HAS_BROKEN_FSTAT_FOR_ZIP_FDS = major > 25 || (major === 25 && minor >= 7);