Skip to content

Add ret_size checking in server keystore#302

Merged
bigbrett merged 2 commits intowolfSSL:mainfrom
padelsbach:padelsbach/ret-size-server-keystore
May 6, 2026
Merged

Add ret_size checking in server keystore#302
bigbrett merged 2 commits intowolfSSL:mainfrom
padelsbach:padelsbach/ret-size-server-keystore

Conversation

@padelsbach
Copy link
Copy Markdown
Contributor

@padelsbach padelsbach commented Mar 17, 2026

Fixes finding 125

@padelsbach padelsbach force-pushed the padelsbach/ret-size-server-keystore branch from 2e17ece to cf37b07 Compare March 17, 2026 19:00
@padelsbach padelsbach marked this pull request as ready for review March 17, 2026 19:48
@padelsbach padelsbach requested a review from bigbrett March 17, 2026 19:48
bigbrett
bigbrett requested changes Mar 17, 2026
View reviewed changes
Comment thread src/wh_server_keystore.c
@padelsbach padelsbach force-pushed the padelsbach/ret-size-server-keystore branch from cf37b07 to 48cdcea Compare March 18, 2026 00:49
@padelsbach padelsbach assigned bigbrett and unassigned padelsbach Mar 18, 2026
@padelsbach padelsbach force-pushed the padelsbach/ret-size-server-keystore branch 2 times, most recently from 072967e to c55e1ad Compare March 19, 2026 19:29
wolfSSL-Fenrir-bot
wolfSSL-Fenrir-bot reviewed Mar 19, 2026
View reviewed changes
Copy link
Copy Markdown

@wolfSSL-Fenrir-bot wolfSSL-Fenrir-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fenrir Automated Review — PR #302

Scan targets checked: wolfhsm-core-bugs, wolfhsm-src

No new issues found in the changed files. ✅

bigbrett
bigbrett requested changes Mar 24, 2026
View reviewed changes
Comment thread src/wh_server_keystore.c
Comment thread test/wh_test.c Outdated
Comment thread test/wh_test_keystore_reqsize.c
@bigbrett bigbrett assigned padelsbach and unassigned bigbrett Mar 24, 2026
@padelsbach padelsbach force-pushed the padelsbach/ret-size-server-keystore branch from c55e1ad to 03b94b4 Compare March 24, 2026 21:49
@padelsbach padelsbach assigned bigbrett and unassigned padelsbach Mar 24, 2026
bigbrett
bigbrett requested changes Mar 25, 2026
View reviewed changes
Comment thread src/wh_server_keystore.c
Comment thread src/wh_server_keystore.c
Comment thread src/wh_server_keystore.c
Comment thread src/wh_server_keystore.c
Comment thread test/wh_test_keystore_reqsize.h Outdated
@padelsbach padelsbach force-pushed the padelsbach/ret-size-server-keystore branch 2 times, most recently from 0054c48 to 5de6c0c Compare March 25, 2026 20:10
@AlexLanzano AlexLanzano assigned padelsbach and unassigned bigbrett Apr 8, 2026
@AlexLanzano
Copy link
Copy Markdown
Member

AlexLanzano commented Apr 8, 2026

@padelsbach Looks like some of the comments by Brett were not addressed

@padelsbach padelsbach force-pushed the padelsbach/ret-size-server-keystore branch from 5de6c0c to a51ad8f Compare April 8, 2026 22:14
@padelsbach
Copy link
Copy Markdown
Contributor Author

padelsbach commented Apr 8, 2026

@padelsbach Looks like some of the comments by Brett were not addressed

Thanks Alex. I fixed the bug ID reference. I believe the other feedback is addressed. Let me know if you see anything specific.

@padelsbach padelsbach assigned AlexLanzano and unassigned padelsbach Apr 8, 2026
@AlexLanzano
Copy link
Copy Markdown
Member

AlexLanzano commented Apr 8, 2026

@padelsbach Looks like some of the comments by Brett were not addressed

Thanks Alex. I fixed the bug ID reference. I believe the other feedback is addressed. Let me know if you see anything specific.

I believe Brett's comments on the format of the WH_SERVER_NVM_LOCK(server); in src/wh_server_keystore.c still need to be addressed

@AlexLanzano AlexLanzano removed their assignment Apr 8, 2026
@padelsbach padelsbach assigned bigbrett and unassigned padelsbach May 4, 2026
bigbrett
bigbrett previously approved these changes May 5, 2026
View reviewed changes
Copy link
Copy Markdown
Contributor

@bigbrett bigbrett left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

test is awkward given how test infra currently works (dont have a pattern where we spoon feed the server raw request structures...) but hopefully will be fixed when migrated in #331.

@bigbrett
Copy link
Copy Markdown
Contributor

bigbrett commented May 5, 2026

@padelsbach can you resolve conflicts plz.

@padelsbach padelsbach force-pushed the padelsbach/ret-size-server-keystore branch from a51ad8f to 1570f97 Compare May 5, 2026 20:59
@bigbrett bigbrett merged commit 1afa4ba into wolfSSL:main May 6, 2026
92 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@wolfSSL-Fenrir-bot wolfSSL-Fenrir-bot wolfSSL-Fenrir-bot left review comments

@bigbrett bigbrett bigbrett approved these changes

Assignees

@bigbrett bigbrett

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@padelsbach @AlexLanzano @bigbrett @wolfSSL-Fenrir-bot