Added font support#6
Conversation
Needs testing before merge
ff3d73e to
7a839eb
Compare
| end | ||
| overrides[name] = parsed_val | ||
| end | ||
| end |
|
I am waiting with finalizing the PR until i have confirmation that this is something youd like pushed back into your repo. Just give me a shout and I'll clean it up a bit. |
Thanks for the PR. I haven't worked on this project in a while so it may take me a bit to re-familiarize myself with the code and review, but yes. I think this would be interesting to have. |
|
Thanks, thats all I need, ill get to cleaning up this PR then. As long as no one uses this plugin to change vars every frame/second, i doubt this will really have a performance impact. I hope its ok that I continue my fork as it deviates from your plugin in the future though. I will add attribution to my repo eventually, right now I am just playing around. No rush on your end, take as much time as you need. |
|
No problem. When I was working on this, I remember Wezterm intermittently wouldn't respond on the first override of a user var, but I don't think it was something this plugin could control and it was impossible to reliably reproduce. Either way, not a big deal. |
Needs testing before merge, my fork is diverging fast as I want to add more functionality that I am not sure fits your vision, as well as performance is not something I am looking at currently. However I added some QOL fixes for font support, now you should in theory be able to just pass it as a string into the function. I have not tested this merge yet, but give me a few days and ill test it and clean it up if needed. Have a good weekend!