fix use of parameters arg in Cursor.execute#43
Closed
james-willis wants to merge 1 commit intomainfrom
Closed
Conversation
There is still a problem - we don't sanitize these inputs even though users would assume that we do
james-willis
force-pushed
the
fix-parameters
branch
from
478f9ac to
22c2331
Compare
peterfoldes
requested changes
Jul 29, 2025
| sql = ( | ||
| operation.replace("{", "{{").replace("}", "}}").format(**(parameters or {})) | ||
| ) | ||
| sql = operation.format(**(parameters or {})) |
Contributor
There was a problem hiding this comment.
We're using pyformat from https://peps.python.org/pep-0249/, so we need those. (the formatting is in the driver)
Contributor
Author
|
The parameter issue was resolved in another pr |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There is still a problem - we don't sanitize these inputs even though users would assume that we do