Skip to content

Simplify popover=hint behaviours & related spec fixes #12345

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
jakearchibald wants to merge 22 commits into
base: main
Choose a base branch
from
+143 −326
Open

Simplify popover=hint behaviours & related spec fixes #12345

Changes from 5 commits
Commits
Show all changes
22 commits
Select commit Hold shift + click to select a range
04c3483
Show popover fixed
jakearchibald Apr 8, 2026
f4714ea
The rest of the owl
jakearchibald Apr 8, 2026
3bca74f
No need to set hideUntil to document
jakearchibald Apr 8, 2026
dc41ca8
Another document set
jakearchibald Apr 8, 2026
4518fd0
Missing return true
jakearchibald Apr 8, 2026
e345ff0
Minor changes
jakearchibald Apr 9, 2026
8f4f8fd
Hint first, and make it clear the conditions are exclusive
jakearchibald Apr 9, 2026
31a54ee
Actually remove the TODO lol
jakearchibald Apr 9, 2026
afc6003
Create algo for closing hint then auto popovers
jakearchibald Apr 9, 2026
d2fd3f5
Fixing silly mistakes
jakearchibald Apr 9, 2026
657f638
Don't hide autos if endpoint is in the hint stack
jakearchibald Apr 10, 2026
84eee6f
Use infra list slice & reverse
jakearchibald Apr 14, 2026
7a71186
Change arg order of popover hide
jakearchibald Apr 17, 2026
470b816
Set hint stack branch earlier
jakearchibald Apr 17, 2026
f6816de
Add missing 'otherwise's
jakearchibald Apr 17, 2026
2dbb9bf
options to arguments
jakearchibald Apr 17, 2026
4937655
Rename cleanupShowingFlag to cleanupShowingSteps
jakearchibald Apr 17, 2026
3e4a889
Correct popover click behavior
jakearchibald Apr 17, 2026
acfe14a
Fix topmost popover ancestor
jakearchibald Apr 17, 2026
0f6701f
Allow auto within hint by downgrading to hint
jakearchibald Apr 17, 2026
f99432c
Disallow showing a popover while another is showing
jakearchibald Apr 17, 2026
7ca5f3d
Prevent showing a popover during the show or hide of another popover
jakearchibald Apr 17, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Loading
Loading