Codify MCP tool name requirements and add title#152
Merged
domfarolino merged 9 commits intowebmachinelearning:mainfrom Apr 9, 2026
Merged
Codify MCP tool name requirements and add title#152domfarolino merged 9 commits intowebmachinelearning:mainfrom
domfarolino merged 9 commits intowebmachinelearning:mainfrom
Conversation
domfarolino
reviewed
Mar 23, 2026
Co-authored-by: Dominic Farolino <[email protected]>
Contributor
Author
|
First of all: Apologies for wasting your time and thank you for being kind about it. Sincerely hope I did better this time 😅. Anyway, I included the checks in the |
domfarolino
reviewed
Mar 24, 2026
Collaborator
domfarolino
left a comment
domfarolino
left a comment
There was a problem hiding this comment.
Don't sweat it, specs are hard! Thanks for the contribution.
Collaborator
|
I've pushed a couple small changes to make this more spec idiomatic. Can you take a look @DavidMulder0? |
domfarolino
approved these changes
Apr 8, 2026
Contributor
Author
|
Thank you! Just fixed a typo and a missing verb. |
domfarolino
approved these changes
Apr 9, 2026
Collaborator
domfarolino
left a comment
domfarolino
left a comment
There was a problem hiding this comment.
Thanks a lot! I've prepared https://crrev.com/c/7744064 and https://crrev.com/c/7742044 to implement these changes in Chromium, and provide web platform tests for them.
github-actions Bot
added a commit
that referenced
this pull request
Apr 9, 2026
SHA: 1380910 Reason: push, by domfarolino Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
brave-builds
pushed a commit
to brave/chromium
that referenced
this pull request
May 6, 2026
The spec PR webmachinelearning/webmcp#152 is tightening tool name validation to match what the MCP specification accepts [1], and we think it's reasonable for the web platform to throw exceptions when tool names do not match this criteria, which is what this CL does. [1]: https://modelcontextprotocol.io/specification/2025-11-25/server/tools#tool-names R=masonf Bug: 489045948 Change-Id: I7d1af5d8cd18e5be7db5ddc9f9ce6d28e73cfd3f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/7744064 Commit-Queue: Dominic Farolino <[email protected]> Reviewed-by: Mason Freed <[email protected]> Cr-Commit-Position: refs/heads/main@{#1625865}
chromium-wpt-export-bot
pushed a commit
to web-platform-tests/wpt
that referenced
this pull request
May 6, 2026
The spec PR webmachinelearning/webmcp#152 is tightening tool name validation to match what the MCP specification accepts [1], and we think it's reasonable for the web platform to throw exceptions when tool names do not match this criteria, which is what this CL does. [1]: https://modelcontextprotocol.io/specification/2025-11-25/server/tools#tool-names R=masonf Bug: 489045948 Change-Id: I7d1af5d8cd18e5be7db5ddc9f9ce6d28e73cfd3f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/7744064 Commit-Queue: Dominic Farolino <[email protected]> Reviewed-by: Mason Freed <[email protected]> Cr-Commit-Position: refs/heads/main@{#1625865}
chromium-wpt-export-bot
pushed a commit
to web-platform-tests/wpt
that referenced
this pull request
May 6, 2026
The spec PR webmachinelearning/webmcp#152 is tightening tool name validation to match what the MCP specification accepts [1], and we think it's reasonable for the web platform to throw exceptions when tool names do not match this criteria, which is what this CL does. [1]: https://modelcontextprotocol.io/specification/2025-11-25/server/tools#tool-names R=masonf Bug: 489045948 Change-Id: I7d1af5d8cd18e5be7db5ddc9f9ce6d28e73cfd3f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/7744064 Commit-Queue: Dominic Farolino <[email protected]> Reviewed-by: Mason Freed <[email protected]> Cr-Commit-Position: refs/heads/main@{#1625865}
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addressing #145 and #133 .
(Related topic: some guidance regarding localization would be great.
namedoes not have to be localized presumably (it won't be shown to the user presumably).titlemay be localized. Willdescriptionbe shown to the end user? From personal experience I am treating that as a solid 'no' (all MCP descriptions I have written so far were 'prompt engineered'). Lastly I have seen the tool arguments get presented to the user relatively often, so should there be a way to localize the display of those?)