Skip to content

Commit 21cb060

Browse files
authored
Merge pull request #2099 from dprevost-LMI/fix-playgrounds
fix: Playgrounds: align webdriverio version, fix null attributes, update visual-snapshots images
2 parents c542164 + 0fe6439 commit 21cb060

14 files changed

Lines changed: 3025 additions & 2613 deletions

File tree

playgrounds/jasmine/package-lock.json

Lines changed: 956 additions & 876 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

playgrounds/jasmine/package.json

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -23,5 +23,8 @@
2323
"expect-webdriverio": "file:../..",
2424
"ts-node": "^10.9.2",
2525
"typescript": "^5.9.3"
26+
},
27+
"overrides": {
28+
"webdriverio": "9.25.0"
2629
}
2730
}

playgrounds/jasmine/test/specs/basic-matchers.test.ts

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -52,7 +52,8 @@ describe('Basic Expect Matchers', () => {
5252
const navLinks = await $$('nav a')
5353
const hrefs: string[] = []
5454
for (const link of navLinks) {
55-
hrefs.push(await link.getAttribute('href'))
55+
const href = await link.getAttribute('href')
56+
if(href !== null) hrefs.push(href)
5657
}
5758

5859
await expect(hrefs).toBeInstanceOf(Array)

playgrounds/jasmine/test/specs/jasmine-specific.test.ts

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -38,7 +38,8 @@ describe('Jasmine-Specific Features', () => {
3838
const navLinks = await $$('nav a')
3939
const hrefs: string[] = []
4040
for (const link of navLinks) {
41-
hrefs.push(await link.getAttribute('href'))
41+
const href = await link.getAttribute('href')
42+
if(href !== null) hrefs.push(href)
4243
}
4344
await expect(hrefs).toEqual(jasmine.arrayContaining(['/docs/gettingstarted']))
4445
})

playgrounds/jest/package-lock.json

Lines changed: 1140 additions & 875 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

playgrounds/jest/package.json

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -24,5 +24,8 @@
2424
"expect-webdriverio": "file:../..",
2525
"ts-node": "^10.9.2",
2626
"typescript": "^5.9.3"
27+
},
28+
"overrides": {
29+
"webdriverio": "9.25.0"
2730
}
2831
}

playgrounds/jest/test/specs/__snapshots__/snapshot.test.ts.snap

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -15,7 +15,7 @@ exports[`DOM snapshots > should match command result snapshot 1`] = `
1515

1616
exports[`DOM snapshots > should match element outerHTML snapshot 1`] = `
1717
"<div class="navbar__logo">
18-
<img src="data:image/svg+xml;base64,PD94bWwgdmVyc2lvbj0iMS4wIiBlbmNvZGluZz0iVVRGLTgiPz4KPHN2ZyB3aWR0aD0iNjRweCIgaGVpZ2h0PSI2NHB4IiB2aWV3Qm94PSIwIDAgNjQgNjQiIHZlcnNpb249IjEuMSIgeG1sbnM9Imh0dHA6Ly93d3cudzMub3JnLzIwMDAvc3ZnIiB4bWxuczp4bGluaz0iaHR0cDovL3d3dy53My5vcmcvMTk5OS94bGluayI+CiAgICA8dGl0bGU+TG9nbyBSZWd1bGFyPC90aXRsZT4KICAgIDxnIGlkPSJMb2dvLVJlZ3VsYXIiIHN0cm9rZT0ibm9uZSIgc3Ryb2tlLXdpZHRoPSIxIiBmaWxsPSJub25lIiBmaWxsLXJ1bGU9ImV2ZW5vZGQiPgogICAgICAgIDxyZWN0IGlkPSJSZWN0YW5nbGUiIGZpbGw9IiNFQTU5MDYiIHg9IjAiIHk9IjAiIHdpZHRoPSI2NCIgaGVpZ2h0PSI2NCIgcng9IjUiPjwvcmVjdD4KICAgICAgICA8cGF0aCBkPSJNOCwxNiBMOCw0OCBMNiw0OCBMNiwxNiBMOCwxNiBaIE00MywxNiBDNTEuODM2NTU2LDE2IDU5LDIzLjE2MzQ0NCA1OSwzMiBDNTksNDAuODM2NTU2IDUxLjgzNjU1Niw0OCA0Myw0OCBDMzQuMTYzNDQ0LDQ4IDI3LDQwLjgzNjU1NiAyNywzMiBDMjcsMjMuMTYzNDQ0IDM0LjE2MzQ0NCwxNiA0MywxNiBaIE0yNywxNiBMMTQuMTA2LDQ3Ljk5OTIwNzggTDExLjk5OSw0Ny45OTkyMDc4IEwyNC44OTQsMTYgTDI3LDE2IFogTTQzLDE4IEMzNS4yNjgwMTM1LDE4IDI5LDI0LjI2ODAxMzUgMjksMzIgQzI5LDM5LjczMTk4NjUgMzUuMjY4MDEzNSw0NiA0Myw0NiBDNTAuNzMxOTg2NSw0NiA1NywzOS43MzE5ODY1IDU3LDMyIEM1NywyNC4yNjgwMTM1IDUwLjczMTk4NjUsMTggNDMsMTggWiIgaWQ9IkNvbWJpbmVkLVNoYXBlIiBmaWxsPSIjRkZGRkZGIj48L3BhdGg+CiAgICA8L2c+Cjwvc3ZnPg==" alt="WebdriverIO" class="themedComponent_wx_6 themedComponent--dark_CdPN" />
18+
<img src="data:image/svg+xml;base64,PD94bWwgdmVyc2lvbj0iMS4wIiBlbmNvZGluZz0iVVRGLTgiPz4KPHN2ZyB3aWR0aD0iNjRweCIgaGVpZ2h0PSI2NHB4IiB2aWV3Qm94PSIwIDAgNjQgNjQiIHZlcnNpb249IjEuMSIgeG1sbnM9Imh0dHA6Ly93d3cudzMub3JnLzIwMDAvc3ZnIiB4bWxuczp4bGluaz0iaHR0cDovL3d3dy53My5vcmcvMTk5OS94bGluayI+CiAgICA8dGl0bGU+TG9nbyBSZWd1bGFyPC90aXRsZT4KICAgIDxnIGlkPSJMb2dvLVJlZ3VsYXIiIHN0cm9rZT0ibm9uZSIgc3Ryb2tlLXdpZHRoPSIxIiBmaWxsPSJub25lIiBmaWxsLXJ1bGU9ImV2ZW5vZGQiPgogICAgICAgIDxyZWN0IGlkPSJSZWN0YW5nbGUiIGZpbGw9IiNFQTU5MDYiIHg9IjAiIHk9IjAiIHdpZHRoPSI2NCIgaGVpZ2h0PSI2NCIgcng9IjUiPjwvcmVjdD4KICAgICAgICA8cGF0aCBkPSJNOCwxNiBMOCw0OCBMNiw0OCBMNiwxNiBMOCwxNiBaIE00MywxNiBDNTEuODM2NTU2LDE2IDU5LDIzLjE2MzQ0NCA1OSwzMiBDNTksNDAuODM2NTU2IDUxLjgzNjU1Niw0OCA0Myw0OCBDMzQuMTYzNDQ0LDQ4IDI3LDQwLjgzNjU1NiAyNywzMiBDMjcsMjMuMTYzNDQ0IDM0LjE2MzQ0NCwxNiA0MywxNiBaIE0yNywxNiBMMTQuMTA2LDQ3Ljk5OTIwNzggTDExLjk5OSw0Ny45OTkyMDc4IEwyNC44OTQsMTYgTDI3LDE2IFogTTQzLDE4IEMzNS4yNjgwMTM1LDE4IDI5LDI0LjI2ODAxMzUgMjksMzIgQzI5LDM5LjczMTk4NjUgMzUuMjY4MDEzNSw0NiA0Myw0NiBDNTAuNzMxOTg2NSw0NiA1NywzOS43MzE5ODY1IDU3LDMyIEM1NywyNC4yNjgwMTM1IDUwLjczMTk4NjUsMTggNDMsMTggWiIgaWQ9IkNvbWJpbmVkLVNoYXBlIiBmaWxsPSIjRkZGRkZGIj48L3BhdGg+CiAgICA8L2c+Cjwvc3ZnPg==" alt="WebdriverIO" class="themedComponent_zHFD themedComponent--dark_Hm17" />
1919
</div>"
2020
`;
2121

playgrounds/jest/test/specs/basic-matchers.test.ts

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -50,7 +50,8 @@ describe('Basic Expect Matchers', () => {
5050
const navLinks = await $$('nav a')
5151
const hrefs: string[] = []
5252
for (const link of navLinks) {
53-
hrefs.push(await link.getAttribute('href'))
53+
const href = await link.getAttribute('href')
54+
if(href !== null) hrefs.push(href)
5455
}
5556

5657
expect(hrefs).toBeInstanceOf(Array)
-8.32 KB
Loading

0 commit comments

Comments
 (0)