Be clear on the intent of filtering out nulls

dprevost-LMI · dprevost-LMI · commit 0fe643972aee · 2026-05-03T08:20:53.000-04:00
diff --git a/playgrounds/jasmine/test/specs/basic-matchers.test.ts b/playgrounds/jasmine/test/specs/basic-matchers.test.ts
@@ -53,7 +53,7 @@ describe('Basic Expect Matchers', () => {
             const hrefs: string[] = []
             for (const link of navLinks) {
                 const href = await link.getAttribute('href')
-                if(href) hrefs.push(href)
+                if(href !== null) hrefs.push(href)
             }
 
             await expect(hrefs).toBeInstanceOf(Array)
diff --git a/playgrounds/jasmine/test/specs/jasmine-specific.test.ts b/playgrounds/jasmine/test/specs/jasmine-specific.test.ts
@@ -39,7 +39,7 @@ describe('Jasmine-Specific Features', () => {
             const hrefs: string[] = []
             for (const link of navLinks) {
                 const href = await link.getAttribute('href')
-                if(href) hrefs.push(href)
+                if(href !== null) hrefs.push(href)
             }
             await expect(hrefs).toEqual(jasmine.arrayContaining(['/docs/gettingstarted']))
         })
diff --git a/playgrounds/jest/test/specs/basic-matchers.test.ts b/playgrounds/jest/test/specs/basic-matchers.test.ts
@@ -51,7 +51,7 @@ describe('Basic Expect Matchers', () => {
             const hrefs: string[] = []
             for (const link of navLinks) {
                 const href = await link.getAttribute('href')
-                if(href) hrefs.push(href)
+                if(href !== null) hrefs.push(href)
             }
 
             expect(hrefs).toBeInstanceOf(Array)
diff --git a/playgrounds/mocha/test/specs/basic-matchers.test.ts b/playgrounds/mocha/test/specs/basic-matchers.test.ts
@@ -51,7 +51,7 @@ describe('Basic Expect Matchers', () => {
             const hrefs: string[] = []
             for (const link of navLinks) {
                 const href = await link.getAttribute('href')
-                if(href) hrefs.push(href)
+                if(href !== null) hrefs.push(href)
             }
 
             expect(hrefs).toBeInstanceOf(Array)

Original file line number	Diff line number	Diff line change
`@@ -53,7 +53,7 @@ describe('Basic Expect Matchers', () => {`
`53`	`53`	`const hrefs: string[] = []`
`54`	`54`	`for (const link of navLinks) {`
`55`	`55`	`const href = await link.getAttribute('href')`
`56`		`- if(href) hrefs.push(href)`
	`56`	`+ if(href !== null) hrefs.push(href)`
`57`	`57`	`}`
`58`	`58`
`59`	`59`	`await expect(hrefs).toBeInstanceOf(Array)`
Original file line number	Diff line number	Diff line change
`@@ -39,7 +39,7 @@ describe('Jasmine-Specific Features', () => {`
`39`	`39`	`const hrefs: string[] = []`
`40`	`40`	`for (const link of navLinks) {`
`41`	`41`	`const href = await link.getAttribute('href')`
`42`		`- if(href) hrefs.push(href)`
	`42`	`+ if(href !== null) hrefs.push(href)`
`43`	`43`	`}`
`44`	`44`	`await expect(hrefs).toEqual(jasmine.arrayContaining(['/docs/gettingstarted']))`
`45`	`45`	`})`
Original file line number	Diff line number	Diff line change
`@@ -51,7 +51,7 @@ describe('Basic Expect Matchers', () => {`
`51`	`51`	`const hrefs: string[] = []`
`52`	`52`	`for (const link of navLinks) {`
`53`	`53`	`const href = await link.getAttribute('href')`
`54`		`- if(href) hrefs.push(href)`
	`54`	`+ if(href !== null) hrefs.push(href)`
`55`	`55`	`}`
`56`	`56`
`57`	`57`	`expect(hrefs).toBeInstanceOf(Array)`