Skip to content

fix(prefill): respect loadOnScroll flag in _prefillNext to prevent auto-load in trigger mode (#886) #888

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Hoang130203 wants to merge 1 commit into
base: master
Choose a base branch
from
Open

fix(prefill): respect loadOnScroll flag in _prefillNext to prevent auto-load in trigger mode (#886) #888

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 10 additions & 0 deletions src/prefill.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,6 +22,16 @@ export default class Prefill {
}

_prefillNext() {
// Respect the loadOnScroll flag. When trigger mode is active,
// Trigger.bind() calls disableLoadOnScroll() during the BINDED event,
// which fires before prefill runs. Without this guard, prefill would
// call next() unconditionally and bypass trigger mode, causing an
// unexpected auto-load on reload when the scroll position is restored
// near the sentinel. See: https://github.com/webcreate/infinite-ajax-scroll/issues/886
if (!this.ias.loadOnScroll) {
return;
}

let distance = this.ias.distance();

if (distance > 0) {
Expand Down