NeoForge support (1.20.6, 1.21.1, 1.21.4)#4183
NeoForge support (1.20.6, 1.21.1, 1.21.4)#4183minimusubi wants to merge 12 commits intowebbukkit:v3.0from
Conversation
Update Gradle to 8.12
|
Can confirm at least for All-The-Mods 10 (1.21.1) it works 🎉 |
|
Not sure if that is due to this PR, but it crashed the server after ~5mins: |
|
This is what I get with ATM10: Full crash report: |
|
Anyone got it working for ATM10? |
|
@ckoval7 interestingly your crash report indicates the crash was from a DynmapIntegration part of a Waystones mod: Same error with a very similar stacktrace (albeit in a Forge top-level context) is mentioned in TwelveIterations/Waystones#863 |
|
OK so in the version cited in your logs (v21.1.17), the fix for TwelveIterations/Waystones#863 is in place: https://github.com/TwelveIterations/Waystones/blob/v21.1.17/common/src/main/java/net/blay09/mods/waystones/compat/DynmapIntegration.java (see TwelveIterations/Waystones@04aef68 for changes made as part of the fix that the issue was closed with) So it could be a regression, or maybe just some other kind of initialization issue leading to that null reference getting hit. The code in question does involve calling |
Adds support for NeoForge on the three relevant versions:
Notes
7.0.1788.12for newer NeoGradle support1.9.2for newer Gradle support* The fabric-loom upgrade was done based off of 30d6845, but after the recent merges, may not be required