Add support for replication.enableMajorityReadConcern setting#544
Open
williamkorb wants to merge 12 commits intovoxpupuli:masterfrom
Open
Add support for replication.enableMajorityReadConcern setting#544williamkorb wants to merge 12 commits intovoxpupuli:masterfrom
williamkorb wants to merge 12 commits intovoxpupuli:masterfrom
Conversation
…etting in mongod.conf.
bastelfreak
reviewed
Jun 8, 2019
| Boolean $handle_creds = $mongodb::params::handle_creds, | ||
| Boolean $store_creds = $mongodb::params::store_creds, | ||
| Array $admin_roles = $mongodb::params::admin_roles, | ||
| Optional[Boolean] $repl_enable_majority_read_concern = undef, |
Member
There was a problem hiding this comment.
Could you make this non optional and default to true? That makes the code here and in the template easier to read.
bastelfreak
added
enhancement
Member
|
Hi @williamkorb, thanks for the work! Can you please take a look at the inline comment I made and afterwards squash the commits? |
|
Dear @williamkorb, thanks for the PR! This is Vox Pupuli Tasks, your friendly Vox Pupuli GitHub Bot. I noticed that your pull request contains merge conflict. Can you please rebase? You can find my sourcecode at voxpupuli/vox-pupuli-tasks |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request (PR) description
Add support for replication.enableMajorityReadConcern setting in mongod.conf.
This Pull Request (PR) fixes the following issues
#542