Merge stat lowering and row count rewriting into single pass over expressions - #9411
Merge stat lowering and row count rewriting into single pass over expressions#9411robert3005 wants to merge 5 commits into
Conversation
Merging this PR will degrade performance by 15.88%
|
| Mode | Benchmark | BASE |
HEAD |
Efficiency | |
|---|---|---|---|---|---|
| ❌ | Simulation | cold_misaligned[(64, 256)] |
4.4 ms | 5.2 ms | -15.88% |
Tip
Investigate this regression by commenting @codspeedbot fix this regression on this PR, or directly use the CodSpeed MCP with your agent.
Comparing rk/lessrewrites (84fdfb7) with develop (b363fb7)
Footnotes
-
89 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports. ↩
|
double get_item slows down small prunes... need to figure out another option |
Signed-off-by: Robert Kruszewski <[email protected]>
Signed-off-by: Robert Kruszewski <[email protected]>
Signed-off-by: Robert Kruszewski <[email protected]>
Signed-off-by: Robert Kruszewski <[email protected]>
Signed-off-by: Robert Kruszewski <[email protected]>
c960813 to
84fdfb7
Compare
Instead of traversing expressions multiple times we do the lowering and row
count substitution at the same time. We also attempt removing duplicate
conditions from and/or predicates on the way up from stat rewriting.
Duplicate reduction is naive and only handles pairs of duplicates and not cases
where duplicates are one chain removed.