TurboQuant again!#7829
Draft
connortsui20 wants to merge 6 commits intodevelopfrom
Draft
Conversation
Signed-off-by: Connor Tsui <[email protected]>
connortsui20
force-pushed
the
ct/tq-pull-out
branch
from
b8ac011 to
507349c
Compare
Signed-off-by: Connor Tsui <[email protected]>
connortsui20
force-pushed
the
ct/tq-pull-out
branch
from
507349c to
51f347e
Compare
Signed-off-by: Connor Tsui <[email protected]>
Signed-off-by: Connor Tsui <[email protected]>
Signed-off-by: Connor Tsui <[email protected]>
gatesn
reviewed
May 7, 2026
| use vortex_array::dtype::session::DTypeSessionExt; | ||
| use vortex_tensor::vector::Vector; | ||
|
|
||
| session.dtypes().register(Vector); |
Contributor
There was a problem hiding this comment.
I think you want to call vortex_tensor::initialize(...)?
We should probably document that initialize functions should be idempotent!
Signed-off-by: Connor Tsui <[email protected]>
connortsui20
force-pushed
the
ct/tq-pull-out
branch
from
6ac170f to
505dd74
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Tracking issue: #7830
Moves TurboQuant out of
vortex-tensorinto a newvortex-turboquantcrate.The first commit was mostly copying and pasting a bunch of code, as well as adding the
unpackmethod to replace canonicalization. The second commit was cleaning up everything holistically.A lot of the code in
vortex-tensorwas reviewed pretty lightly because we knew that it was unstable, but now that we are more certain about the implementation (not necessarily about the exact design, but the actual implementation of the TQ algorithms), I think it is worth reviewing everything as a whole.Testing
These tests were mostly there before, but now there are more!