fix: REPL display, /compact panic, identity leak, DeepSeek reasoning, thinking blocks#3001
Merged
code-yeongyu merged 1 commit intomainfrom May 6, 2026
Merged
fix: REPL display, /compact panic, identity leak, DeepSeek reasoning, thinking blocks#3001code-yeongyu merged 1 commit intomainfrom
code-yeongyu merged 1 commit intomainfrom
Conversation
… thinking blocks Five interrelated fixes from parallel Hephaestus sessions: 1. fix(repl): display assistant text after spinner (#2981, #2982, #2937) - Added final_assistant_text() call after run_turn spinner completes - REPL now shows response text like run_prompt_json does 2. fix(compact): handle Thinking content blocks (#2985) - Added ContentBlock::Thinking variant throughout compact summarizer - Prevents panic when /compact encounters thinking blocks 3. fix(prompt): provider-aware model identity (#2822) - New ModelFamilyIdentity enum (Claude vs Generic) - Non-Anthropic models no longer say 'I am Claude' - model_family_identity_for() detects provider and sets identity 4. fix(openai): preserve DeepSeek reasoning_content (#2821) - Stream parser now captures reasoning_content from OpenAI-compat - Emits ThinkingDelta/SignatureDelta events for reasoning models - Thinking blocks included in conversation history for re-send 5. feat(runtime): Thinking block support across codebase - AssistantEvent::Thinking variant in conversation.rs - ContentBlock::Thinking in session serialization - Thinking-aware compact summarization - Tests for thinking block ordering and content Closes #2981, #2982, #2937, #2985, #2822, #2821
This was referenced May 6, 2026
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Five interrelated fixes from parallel Hephaestus sessions:
Changes
1. fix(repl): display assistant text after spinner (#2981, #2982, #2937)
final_assistant_text()call afterrun_turnspinner completesrun_prompt_jsondoes2. fix(compact): handle Thinking content blocks (#2985)
ContentBlock::Thinkingvariant throughout compact summarizer/compactencounters thinking blocks3. fix(prompt): provider-aware model identity (#2822)
ModelFamilyIdentityenum (Claude vs Generic)model_family_identity_for()detects provider and sets identity4. fix(openai): preserve DeepSeek reasoning_content (#2821)
reasoning_contentfrom OpenAI-compat responsesThinkingDelta/SignatureDeltaevents for reasoning models5. feat(runtime): Thinking block support across codebase
AssistantEvent::Thinkingvariant in conversation.rsContentBlock::Thinkingin session serializationTesting
cargo test --workspacepassescargo fmt --allcleancargo clippy --workspaceclean (only pre-existing warnings)Closes #2981, #2982, #2937, #2985, #2822, #2821