fix: tolerate object-style hook entries in config parser#3000
Open
justcode049 wants to merge 4 commits intoultraworkers:mainfrom
Open
fix: tolerate object-style hook entries in config parser#3000justcode049 wants to merge 4 commits intoultraworkers:mainfrom
justcode049 wants to merge 4 commits intoultraworkers:mainfrom
Conversation
The official Claude Code settings format uses structured hook objects
({matcher, hooks: [{type, command}]}) but the parser only accepted
plain string arrays, causing a parse error on any machine with
standard hook configuration.
Co-Authored-By: Claude Opus 4.6 (1M context) <[email protected]>
Collaborator
|
This PR has merge conflicts with the latest main. Please rebase on |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
field PreToolUse must contain only stringswhen the user's~/.claude/settings.jsoncontained the official Claude Code hook format (structured objects withmatcher,hooks: [{type, command}])optional_string_arraynow gracefully handles both plain string arrays and object-style hook entries, extractingcommandstrings from the latterTest plan
config_report_supports_section_views,config_report_uses_sectioned_layout,status_context_reads_real_workspace_metadata) now passcargo build --workspacesucceeds🤖 Generated with Claude Code