Issue_458: Improved error message for incorrect timestamp format#519
Open
Abigael-JT wants to merge 3 commits intoteragrep:mainfrom
Open
Issue_458: Improved error message for incorrect timestamp format#519Abigael-JT wants to merge 3 commits intoteragrep:mainfrom
Abigael-JT wants to merge 3 commits intoteragrep:mainfrom
Conversation
Contributor
Abigael-JT
commented
Mar 5, 2025
Abigael-JT
commented
- Improved error message for incorrect timestamp format
- Added a debug log message for unparseable relative timestamp
Contributor
|
#454 has some changes for timestamp parsing, perhaps that one should be merged first? |
Contributor
Author
|
Yes that's right, we will revisit these changes after that PR is merged |
Contributor
Author
|
Rebased and updated changes after #454 was merged |
eemhu
reviewed
Apr 8, 2025
eemhu
reviewed
Apr 8, 2025
eemhu
approved these changes
Apr 14, 2025
Contributor
eemhu
left a comment
eemhu
left a comment
There was a problem hiding this comment.
Changes look good to me, tests pass OK
Contributor
|
#572 conflicts with these changes perhaps it's better to wait for a merge and apply these changes after |
Contributor
Author
|
Will resolve merge conflicts after #572 is merged |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.