add spotless#106
Conversation
Tiihott
left a comment
Tiihott
left a comment
There was a problem hiding this comment.
Tests pass and spotless check/apply work as expected. But the Spotless configuration is missing the <toggleOffOn></toggleOffOn> which should be added.
kortemik
requested review from
StrongestNumber9
and removed request for
kortemik
|
@StrongestNumber9 please verify and approve if ok |
# Conflicts: # src/test/java/com/teragrep/pth_03/tests/TeragrepSyntaxTests.java
|
rebased after #112 and applied spotless again |
|
Comments about going with |
sure ok |
| /* | ||
| * Teragrep Data Processing Language Parser Library PTH-03 | ||
| * Copyright (C) 2019-2026 Suomen Kanuuna Oy | ||
| * Data Processing Language (DPL) parser |
There was a problem hiding this comment.
Should the title match the GitHub description or no?
| * GNU Affero General Public License for more details. | ||
| * | ||
| * You should have received a copy of the GNU Affero General Public License | ||
| * along with this program. If not, see <https://github.com/teragrep/teragrep/blob/main/LICENSE>. |
There was a problem hiding this comment.
It is like that in the mvn_01 the template: https://github.com/teragrep/mvn_01/blob/main/example-java-project/header.
The same pattern is present in many other projects like in PTH_10
| <?xml version="1.0" encoding="UTF-8" standalone="no"?> | ||
| <!-- | ||
| Data Processing Language (DPL) parser | ||
| Copyright (C) 2025 Suomen Kanuuna Oy |
| <license implementation="org.apache.rat.analysis.license.SimplePatternBasedLicense"> | ||
| <notes>Also allow the license url to be https.</notes> | ||
| <patterns> | ||
| <pattern>Copyright (C) 2019, 2020, 2021, 2022 Suomen Kanuuna Oy</pattern> |
4 participants
Description
Add spotless plugin and apply.
.javaand.g4files.txtor.xmlfilesNotes
.txtand.xmlfiles both have different types of comment styles and would there require their own license files, decided not to add.