Skip to content

fix: remove redundant to/memo from DecryptionData #364

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
dankrad wants to merge 4 commits into
base: main
Choose a base branch
from
Open

fix: remove redundant to/memo from DecryptionData #364

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
5c7f28b
fix: remove redundant to/memo from DecryptionData
dankrad Apr 7, 2026
2a0ed53
Merge branch 'main' into fix/decryption-data-trim
dankrad Apr 17, 2026
3bdc0a6
Merge branch 'main' into fix/decryption-data-trim
dankrad Apr 20, 2026
8145565
test: regenerate zone-test-genesis with Address::ZERO tempo_portal
dankrad Apr 20, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions crates/primitives/src/abi.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -386,12 +386,11 @@ macro_rules! define_abi {
}

/// Decryption data provided by the sequencer for encrypted deposits.
/// The decrypted (to, memo) are derived on-chain from the AES-GCM decryption.
#[derive(Debug)]
struct DecryptionData {
bytes32 sharedSecret;
uint8 sharedSecretYParity;
address to;
bytes32 memo;
ChaumPedersenProof cpProof;
}

Expand Down
2 changes: 0 additions & 2 deletions crates/tempo-zone/src/builder.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -689,8 +689,6 @@ mod tests {
decryptions: vec![abi::DecryptionData {
sharedSecret: B256::ZERO,
sharedSecretYParity: 0x02,
to: sender,
memo: B256::ZERO,
cpProof: abi::ChaumPedersenProof {
s: B256::ZERO,
c: B256::ZERO,
Expand Down
45 changes: 5 additions & 40 deletions crates/tempo-zone/src/l1.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1126,7 +1126,7 @@ impl L1BlockDeposits {
self,
sequencer_key: &k256::SecretKey,
portal_address: Address,
policy_provider: &crate::l1_state::PolicyProvider,
_policy_provider: &crate::l1_state::PolicyProvider,
) -> eyre::Result<PreparedL1Block> {
use crate::precompiles::ecies;

Expand Down Expand Up @@ -1192,46 +1192,15 @@ impl L1BlockDeposits {
recipient = %dec.to,
token = %d.token,
amount = %d.amount,
"Decrypted encrypted deposit, checking policy"
"Decrypted encrypted deposit"
);

// Check TIP-403 policy via the provider (cache-first, RPC fallback).
// Errors are propagated so the engine retries rather than allowing
// unauthorized deposits through.
let authorized = policy_provider
.is_authorized_async(
d.token,
dec.to,
l1_block_number,
crate::l1_state::AuthRole::MintRecipient,
)
.await?;

let recipient = if authorized {
debug!(
target: "zone::engine",
recipient = %dec.to,
token = %d.token,
"Policy authorized encrypted deposit recipient"
);
dec.to
} else {
warn!(
target: "zone::engine",
sender = %d.sender,
recipient = %dec.to,
token = %d.token,
amount = %d.amount,
"Encrypted deposit recipient unauthorized, redirecting to sender"
);
d.sender
};

// TIP-403 policy enforcement happens on-chain: ZoneInbox
// wraps the mint in try/catch and falls back to crediting
// the depositor if the recipient is unauthorized.
let decryption = abi::DecryptionData {
sharedSecret: dec.proof.shared_secret,
sharedSecretYParity: dec.proof.shared_secret_y_parity,
to: recipient,
memo: dec.memo,
cpProof: abi::ChaumPedersenProof {
s: dec.proof.cp_proof_s,
c: dec.proof.cp_proof_c,
Expand Down Expand Up @@ -1259,8 +1228,6 @@ impl L1BlockDeposits {
let decryption = abi::DecryptionData {
sharedSecret: proof.shared_secret,
sharedSecretYParity: proof.shared_secret_y_parity,
to: d.sender,
memo: B256::ZERO,
cpProof: abi::ChaumPedersenProof {
s: proof.cp_proof_s,
c: proof.cp_proof_c,
Expand All @@ -1280,8 +1247,6 @@ impl L1BlockDeposits {
let decryption = abi::DecryptionData {
sharedSecret: B256::ZERO,
sharedSecretYParity: 0x02,
to: d.sender,
memo: B256::ZERO,
cpProof: abi::ChaumPedersenProof {
s: B256::ZERO,
c: B256::ZERO,
Expand Down
2 changes: 0 additions & 2 deletions crates/tempo-zone/tests/advance_tempo.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,8 +38,6 @@ sol! {
struct DecryptionData {
bytes32 sharedSecret;
uint8 sharedSecretYParity;
address to;
bytes32 memo;
ChaumPedersenProof cpProof;
}
struct EnabledToken {
Expand Down
50 changes: 5 additions & 45 deletions crates/tempo-zone/tests/assets/zone-test-genesis.json
View file
Open in desktop

Large diffs are not rendered by default.

Loading
Loading