cfg: fix all selector exclusion - #548
Merged
Merged
Conversation
This patch fixes a bug where `exclude = {'all'}` disabled only built-in
metric groups, while custom metric selectors could still be collected.
Closes #547
mandesero
force-pushed
the
mandesero/gh-547-exclude-selectors
branch
from
June 25, 2026 07:01
75db04c to
9e5fc9b
Compare
patapenka-alexey
approved these changes
Jun 25, 2026
patapenka-alexey
left a comment
patapenka-alexey
left a comment
Contributor
There was a problem hiding this comment.
Thank you for the patch!
bigbes
approved these changes
Jun 26, 2026
oleg-jukovec
approved these changes
Jun 26, 2026
Merged
mandesero
added a commit
to mandesero/tarantool
that referenced
this pull request
Jul 2, 2026
Bump metric package submodule to 1.8.1. Commits from PR[1] fixes bugs. 1. tarantool/metrics#548 NO_TEST=metrics submodule bump NO_DOC=bugfix
sergepetrenko
pushed a commit
to tarantool/tarantool
that referenced
this pull request
Jul 3, 2026
Bump metric package submodule to 1.8.1. Commits from PR[1] fixes bugs. 1. tarantool/metrics#548 NO_TEST=metrics submodule bump NO_DOC=bugfix
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This patch fixes a bug where
exclude = {'all'}disabled only built-in metric groups, while custom metric selectors could still be collected.Closes #547