[Source Warning Control] Rename '@warn' to '@diagnose'#3305
Open
artemcm wants to merge 1 commit intoswiftlang:mainfrom
Open
[Source Warning Control] Rename '@warn' to '@diagnose'#3305artemcm wants to merge 1 commit intoswiftlang:mainfrom
artemcm wants to merge 1 commit intoswiftlang:mainfrom
Conversation
Contributor
Author
|
@swift-ci test |
artemcm
force-pushed
the
DiagnoseAttr
branch
2 times, most recently
from
30e2ab1 to
0c612fb
Compare
Contributor
Author
|
@swift-ci test |
artemcm
requested review from
ahoppen,
hamishknight,
hborla and
rintaro
as code owners
ahoppen
reviewed
Apr 3, 2026
| } | ||
|
|
||
| func testWarnSpellingBackwardCompat() throws { | ||
| // The old @warn spelling should continue to work as an alias |
Member
There was a problem hiding this comment.
Should we emit a warning for the @warn spelling?
Contributor
Author
There was a problem hiding this comment.
I think doing so in the compiler is probably sufficient:
Contributor
Author
|
@swift-ci test |
1 similar comment
Contributor
Author
|
@swift-ci test |
ahoppen
approved these changes
Apr 17, 2026
Contributor
Author
|
@swift-ci test |
Contributor
Author
|
@swift-ci test |
Contributor
Author
|
@swift-ci test Windows platform |
al45tair
approved these changes
Apr 27, 2026
Contributor
Author
|
Needs swiftlang/swift-build#1348 to land for the failing jobs to go green. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addressing feedback of the ongoing proposal review.
Corresponding proposal amendments in [SE-0522] Address Review Feedback swift-evolution#3206.
Companion change to [Source Warning Control] Rename
@warnto@diagnose& prevent printing it in Textual Interfaces swift#88205Affects only uses of the
@warnattribute, which has only so far existed as an experimental feature. Preserves the old spelling for compatibility.rdar://173774670
Low, due to only affecting feature-gated code.
Test suite amended with the new spelling with backwards-compatibility tests added for the old spelling.
@ahoppen