-
Notifications
You must be signed in to change notification settings - Fork 501
[SwiftLexicalLookup] Add ScopeSyntax conformance for EnumCaseDeclSyntax #3280
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
Ronitsabhaya75
wants to merge
1
commit into
swiftlang:main
Choose a base branch
from
Ronitsabhaya75:enum-case-scope-lookup
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+142
−0
Open
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
71 changes: 71 additions & 0 deletions
71
Sources/SwiftLexicalLookup/Scopes/EnumCaseDeclSyntax.swift
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,71 @@ | ||
| //===----------------------------------------------------------------------===// | ||
| // | ||
| // This source file is part of the Swift.org open source project | ||
| // | ||
| // Copyright (c) 2014 - 2026 Apple Inc. and the Swift project authors | ||
| // Licensed under Apache License v2.0 with Runtime Library Exception | ||
| // | ||
| // See https://swift.org/LICENSE.txt for license information | ||
| // See https://swift.org/CONTRIBUTORS.txt for the list of Swift project authors | ||
| // | ||
| //===----------------------------------------------------------------------===// | ||
|
|
||
| import SwiftSyntax | ||
|
|
||
| @_spi(Experimental) extension EnumCaseDeclSyntax: ScopeSyntax { | ||
| /// Associated-value parameter names introduced by this case declaration. | ||
| /// | ||
| /// Names are position-gated and only visible inside default-value expressions | ||
| /// of subsequent parameters within the same case element, e.g.: | ||
| /// ```swift | ||
| /// enum E { | ||
| /// case foo(x: Int, y: Int = x) // `x` visible in `y`'s default | ||
| /// } | ||
| /// ``` | ||
| /// Parameters from one case element are not visible inside another. | ||
| @_spi(Experimental) public var defaultIntroducedNames: [LookupName] { | ||
| elements.flatMap { element in | ||
| element.parameterClause?.parameters.flatMap { param in | ||
| LookupName.getNames(from: param) | ||
| } ?? [] | ||
| } | ||
| } | ||
|
|
||
| @_spi(Experimental) public var scopeDebugName: String { | ||
| "EnumCaseDeclScope" | ||
| } | ||
|
|
||
| /// Looks up `identifier` from inside this case declaration. | ||
| /// | ||
| /// Only introduces names when lookup originates from a parameter's | ||
| /// default-value expression. Names visible are those of all prior | ||
| /// parameters within the same case element. | ||
| /// | ||
| /// Lookup from outside the declaration (e.g. in the enum body) is | ||
| /// forwarded to the parent scope with no names introduced. | ||
| @_spi(Experimental) public func lookup( | ||
| _ identifier: Identifier?, | ||
| at lookUpPosition: AbsolutePosition, | ||
| with config: LookupConfig | ||
| ) -> [LookupResult] { | ||
| for element in elements { | ||
| guard let paramClause = element.parameterClause else { continue } | ||
|
|
||
| for (index, param) in paramClause.parameters.enumerated() { | ||
| guard let defaultValue = param.defaultValue, | ||
| defaultValue.range.contains(lookUpPosition) | ||
| else { continue } | ||
|
|
||
| // Collect names from params before this one in the same element. | ||
| let priorNames = paramClause.parameters.prefix(index).flatMap { prior in | ||
| LookupName.getNames(from: prior) | ||
| }.filter { $0.refersTo(identifier) } | ||
|
|
||
| return LookupResult.getResultArray(for: self, withNames: priorNames) | ||
| + lookupInParent(identifier, at: lookUpPosition, with: config) | ||
| } | ||
| } | ||
|
|
||
| return lookupInParent(identifier, at: lookUpPosition, with: config) | ||
| } | ||
| } | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this true? As far as I tried,
xis not visible from the default value ofy. Am I missing anything?