Skip to content

Support CLI on Windows by refactoring scripts to console_scripts #177

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
RH-TLagrone wants to merge 2 commits into
base: master
Choose a base branch
from
+14 −7
Open

Support CLI on Windows by refactoring scripts to console_scripts #177

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
93643af
Support CLI on Windows by refactoring scripts to console_scripts
RH-TLagrone Dec 12, 2025
9210541
Apply suggestions from code review
stefankoegl Mar 20, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
0 jsonpatch.py → jsonpatch/__init__.py
View file
Open in desktop
File renamed without changes.
0 bin/jsondiff → jsonpatch/_jsondiff_cli.py
100755 → 100644
View file
Open in desktop
File renamed without changes.
0 bin/jsonpatch → jsonpatch/_jsonpatch_cli.py
100755 → 100644
View file
Open in desktop
File renamed without changes.
17 changes: 12 additions & 5 deletions setup.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,15 +10,17 @@
from distutils.core import setup
has_setuptools = False

src = io.open('jsonpatch.py', encoding='utf-8').read()
src = io.open('jsonpatch/__init__.py', encoding='utf-8').read()
metadata = dict(re.findall("__([a-z]+)__ = '([^']+)'", src))
docstrings = re.findall('"""([^"]*)"""', src, re.MULTILINE | re.DOTALL)

PACKAGE = 'jsonpatch'

MODULES = (
'jsonpatch',
)
MODULES = [
'jsonpatch',
'jsonpatch._jsondiff_cli',
'jsonpatch._jsonpatch_cli',
]
Comment thread
stefankoegl marked this conversation as resolved.

Comment on lines +19 to 24
Copy link

Copilot AI Mar 20, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

MODULES is now unused (it’s defined but never passed to setup() anymore). Please remove it to avoid confusion, or reintroduce py_modules/packages logic that actually uses it.

Suggested change
MODULES = [
'jsonpatch',
'jsonpatch._jsondiff_cli',
'jsonpatch._jsonpatch_cli',
]

Copilot uses AI. Check for mistakes.
REQUIREMENTS = list(open('requirements.txt'))

Expand Down Expand Up @@ -79,7 +81,12 @@
url=WEBSITE,
py_modules=MODULES,
package_data={'': ['requirements.txt']},
scripts=['bin/jsondiff', 'bin/jsonpatch'],
entry_points={
'console_scripts': [
'jsondiff = jsonpatch._jsondiff_cli:main',
'jsonpatch = jsonpatch._jsonpatch_cli:main',
]
},
Comment thread
stefankoegl marked this conversation as resolved.
Outdated
classifiers=CLASSIFIERS,
python_requires='>=2.7, !=3.0.*, !=3.1.*, !=3.2.*, !=3.3.*, !=3.4.*, !=3.5.*, !=3.6.*',
project_urls={
Expand Down
Loading