Skip to content

fix: follow-up fixes from develop commit review (2026-05-06)#11966

Draft
Planeshifter wants to merge 3 commits intodevelopfrom
philipp/fix-commit-review-2026-05-06
Draft

fix: follow-up fixes from develop commit review (2026-05-06)#11966
Planeshifter wants to merge 3 commits intodevelopfrom
philipp/fix-commit-review-2026-05-06

Conversation

@Planeshifter
Copy link
Copy Markdown
Member

Description

What is the purpose of this pull request?

This pull request:

  • Follows up on commits merged to develop between 2026-05-05 15:11 PT and 2026-05-06 04:46 PT (range 74e79f9..1481c95, 25 commits, 121 files) with high-signal corrections to the two new ndarray/base packages introduced in the window.

Fixes grouped by package:

ndarray/base/output-order (commit 52bc84e)

  • Fix benchmark in lib/node_modules/@stdlib/ndarray/base/output-order/benchmark/benchmark.js (52bc84e) where the loop body erroneously wrapped arr[ i%arr.length ] in an extra array literal, causing outputOrder to receive [ [ ndA, ndB ] ] and always fall back to the default order; drop the outer brackets so the benchmark exercises the intended code path.
  • Fix argument spacing in lib/node_modules/@stdlib/ndarray/base/output-order/benchmark/benchmark.js (52bc84e): three array() calls were missing the required space before the closing parenthesis per the stdlib style guide.
  • Fix $ExpectType annotation in lib/node_modules/@stdlib/ndarray/base/output-order/docs/types/test.ts (52bc84e): Layout was incorrect; return type is Order, consistent with ndarray/base/order conventions.

ndarray/base/consensus-order (commit b3ec3d3)

  • Fix lib/node_modules/@stdlib/ndarray/base/consensus-order/docs/types/test.ts (b3ec3d3): rename copy-paste alias consensusLayout to consensusOrder and correct $ExpectType annotation from Layout to Order.

Related Issues

Does this pull request have any related issues?

None.

Questions

Any questions for reviewers of this pull request?

No.

Other

Any other information relevant to this pull request? This may include screenshots, references, and/or implementation notes.

Validation. The window's union diff was scanned by four independent reviewers (two style-guide compliance audits against docs/style-guides and reference packages ndarray/base/order / blas/base/ndarray/dscal; two bug audits — one diff-only, one logic/security on the introduced code). Only findings that were either reported by two or more reviewers or independently re-verifiable from the diff were retained.

Deliberately excluded.

  • to-reversed-dimensions/README.md <related-links> placeholder comments: verified false positive — those markers are an established stdlib convention present in 29 other ndarray/base packages.
  • consensus-order/package.json description ("Resolve the most common underlying storage layout."): subjective; the description is a complete sentence and not a clear style violation.
  • Cauchy validation reorderings, C API_SUFFIX wrapper fixes, internal-utility replacements in blas/ext/{linspace,unitspace} and ndarray/concat*: reviewed and confirmed correct.

Checklist

Please ensure the following tasks are completed before submitting this pull request.

AI Assistance

When authoring the changes proposed in this PR, did you use any kind of AI assistance?

  • Yes
  • No

If you answered "yes" above, how did you use AI assistance?

  • Code generation (e.g., when writing an implementation or fixing a bug)
  • Test/benchmark generation
  • Documentation (including examples)
  • Research and understanding

Disclosure

If you answered "yes" to using AI assistance, please provide a short disclosure indicating how you used AI assistance. This helps reviewers determine how much scrutiny to apply when reviewing your contribution. Example disclosures: "This PR was written primarily by Claude Code." or "I consulted ChatGPT to understand the codebase, but the proposed changes were fully authored manually by myself.".

This PR was prepared by Claude Code: a multi-agent review of commits merged to develop in the previous 24 hours surfaced the high-signal issues, and the fixes were applied programmatically. Each finding was cross-validated by at least two reviewers or independently re-verified against the diff before inclusion.



Generated by Claude Code

claude added 2 commits May 6, 2026 12:20
The benchmark double-wrapped the input list and used a `Layout` type
assertion that diverges from the declared `Order` return type. Pass the
inner list of ndarrays directly, add the missing argument-spacing in
`array()` calls, and align the type-test annotation with the
declaration.
Rename the import alias `consensusLayout` to the canonical
`consensusOrder` and update the `$ExpectType` annotation from `Layout`
to `Order` so the type test matches the function declaration.
@stdlib-bot
Copy link
Copy Markdown
Contributor

stdlib-bot commented May 6, 2026

Coverage Report

Package Statements Branches Functions Lines
ndarray/base/consensus-order $\color{red}209/211$
$\color{green}+0.00%$
$\color{red}15/16$
$\color{green}+0.00%$
$\color{green}2/2$
$\color{green}+0.00%$
$\color{red}209/211$
$\color{green}+0.00%$
ndarray/base/output-order $\color{green}117/117$
$\color{green}+0.00%$
$\color{green}8/8$
$\color{green}+0.00%$
$\color{green}1/1$
$\color{green}+0.00%$
$\color{green}117/117$
$\color{green}+0.00%$

The above coverage report was generated for the changes in this PR.

`eslint-plugin-expect-type` resolves transparent type aliases when
reporting the inferred return type. Because `Order = Layout` in
`@stdlib/types/ndarray`, the plugin always reports `Layout` and the
`$ExpectType Order` annotation fails the lint check.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants