Skip to content

fix(android): prevent double status bar offset in legacy non edge-to-edge mode #3970

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
gusgushz wants to merge 1 commit into
base: main
Choose a base branch
from
+15 −1
Open

fix(android): prevent double status bar offset in legacy non edge-to-edge mode #3970

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 15 additions & 1 deletion android/src/main/java/com/swmansion/rnscreens/CustomToolbar.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,7 @@ import android.view.Choreographer
import android.view.WindowInsets
import android.view.WindowManager
import androidx.appcompat.widget.Toolbar
import androidx.core.view.ViewCompat
import androidx.core.view.WindowInsetsCompat
import com.facebook.react.modules.core.ReactChoreographer
import com.facebook.react.uimanager.ThemedReactContext
Expand Down Expand Up @@ -125,7 +126,20 @@ open class CustomToolbar(
val topInset = getDecorViewTopInset(decorView)

if (topInset > 0) {
applyExactPadding(paddingLeft, topInset, paddingRight, paddingBottom)
// In legacy (non edge-to-edge) mode, the system already positions the toolbar
// below the status bar, so applying paddingTop would cause double offset.
// We detect this by comparing toolbar's position on screen with the status bar inset:
// in edge-to-edge the toolbar starts at y=0, in legacy it starts at y=statusBarInset.
val insetsCompat = ViewCompat.getRootWindowInsets(decorView)
val statusBarInset = insetsCompat?.getInsets(WindowInsetsCompat.Type.statusBars())?.top ?: 0
val locationOnScreen = IntArray(2)
getLocationOnScreen(locationOnScreen)
val toolbarTopOnScreen = locationOnScreen[1]
val isEdgeToEdge = toolbarTopOnScreen < statusBarInset

if (isEdgeToEdge) {
applyExactPadding(paddingLeft, topInset, paddingRight, paddingBottom)
}
}
}

Expand Down