fix(web, SafeAreaView): add named export alongside default export#3956
Open
roryabraham wants to merge 1 commit intosoftware-mansion:mainfrom
Open
fix(web, SafeAreaView): add named export alongside default export#3956roryabraham wants to merge 1 commit intosoftware-mansion:mainfrom
roryabraham wants to merge 1 commit intosoftware-mansion:mainfrom
Conversation
The safe-area/index.ts re-exports SafeAreaView as a named export:
export { SafeAreaView } from './SafeAreaView';
For web builds, webpack resolves './SafeAreaView' to './SafeAreaView.web.tsx',
which only has a default export. This causes a ModuleDependencyWarning at
build time since the named export 'SafeAreaView' cannot be found.
Add a named export to SafeAreaView.web.tsx so it is consistent with how
it is imported throughout the package (e.g. in ScreenStackItem.tsx).
Made-with: Cursor
kkafar
reviewed
Apr 29, 2026
Member
kkafar
left a comment
kkafar
left a comment
There was a problem hiding this comment.
Hey, thanks for catching this & PR.
If this is an regression introduced in beta version, we can get rid of the default export entirely.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
safe-area/index.tsre-exportsSafeAreaViewas a named export:For web builds, webpack resolves
'./SafeAreaView'to'./SafeAreaView.web.tsx', which only has adefaultexport:This causes a
ModuleDependencyWarningat build time:This also affects
ScreenStackItem.tsx, which does:For web builds this resolves to the
.webvariant, again hitting the same missing named export.Fix
Add
export { SafeAreaView }toSafeAreaView.web.tsxso the named export is available consistently with how the rest of the package imports it.Test plan
Related
Found while upgrading
react-native-screensto4.25.0-beta.1in Expensify/App#89199.Made with Cursor