Skip to content

Commit d7833a6

Browse files
authored
Use object.ReferenceEquals for reference type equality comparison (#1277)
1 parent 3429dfd commit d7833a6

4 files changed

Lines changed: 7 additions & 6 deletions

File tree

src/core/SIP/SIPEndPoint.cs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -244,7 +244,7 @@ public override bool Equals(object obj)
244244

245245
public static bool operator ==(SIPEndPoint endPoint1, SIPEndPoint endPoint2)
246246
{
247-
if ((object)endPoint1 == null && (object)endPoint2 == null)
247+
if (object.ReferenceEquals(endPoint1, endPoint2))
248248
{
249249
return true;
250250
}

src/core/SIP/SIPParameters.cs

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
//-----------------------------------------------------------------------------
1+
//-----------------------------------------------------------------------------
22
// Filename: SIPParameters.cs
33
//
44
// Description: SIP parameters as used in Contact, To, From and Via SIP headers.
@@ -16,6 +16,7 @@
1616
using System;
1717
using System.Collections.Generic;
1818
using System.Linq;
19+
using System.Net;
1920
using System.Runtime.Serialization;
2021
using Microsoft.Extensions.Logging;
2122
using SIPSorcery.Sys;
@@ -337,7 +338,7 @@ public override bool Equals(object obj)
337338
/// </summary>
338339
public static bool operator ==(SIPParameters x, SIPParameters y)
339340
{
340-
if (x is null && y is null)
341+
if (object.ReferenceEquals(x, y))
341342
{
342343
return true;
343344
}

src/core/SIP/SIPURI.cs

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
//-----------------------------------------------------------------------------
1+
//-----------------------------------------------------------------------------
22
// Filename: SIPURI.cs
33
//
44
// Description: SIP URI.
@@ -605,7 +605,7 @@ public override bool Equals(object obj)
605605

606606
public static bool operator ==(SIPURI uri1, SIPURI uri2)
607607
{
608-
if (uri1 is null && uri2 is null)
608+
if (object.ReferenceEquals(uri1, uri2))
609609
{
610610
return true;
611611
}

src/net/STUN/STUNUri.cs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -268,7 +268,7 @@ public override bool Equals(object obj)
268268

269269
public static bool operator ==(STUNUri uri1, STUNUri uri2)
270270
{
271-
if (uri1 is null && uri2 is null)
271+
if (object.ReferenceEquals(uri1, uri2))
272272
{
273273
return true;
274274
}

0 commit comments

Comments
 (0)