Conversation
…sqlite, postgres, mysql)
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR adds SQL repository support with multiple backends (SQLite, PostgreSQL, MySQL) as an alternative to the existing local key-value store. The implementation uses GORM as the ORM layer and provides a unified interface through the existing Repository interface.
Key Changes
- Implemented SQL repository with support for SQLite, PostgreSQL, and MySQL backends
- Added command-line flags and environment variables for configuring repository backend and DSN
- Integrated SQL repository into the main application with backend selection logic
Reviewed Changes
Copilot reviewed 5 out of 6 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| pkg/repository/sql.go | New SQL repository implementation with GORM-based storage for OAuth sessions, clients, and PKCE requests |
| pkg/repository/sql_test.go | Basic tests for SQL repository functionality covering access token sessions and unsupported driver handling |
| pkg/mcp-proxy/main.go | Added backend selection logic to initialize either KVS or SQL repository based on configuration |
| main.go | Added CLI flags and environment variables for repository backend and DSN configuration |
| go.mod | Added GORM and SQL driver dependencies for SQLite, PostgreSQL, and MySQL |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Codecov Report❌ Patch coverage is
📢 Thoughts on this report? Let us know! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
#84
Type of Change
Related Issues