fix: implement OAuth CSRF protection with state validation#30
Merged
Conversation
- Generate cryptographically secure random state for OAuth requests - Store OAuth state in session during authorization - Validate state parameter in callback handlers - Add GenerateState utility function for secure random generation Fixes #27
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR implements OAuth CSRF protection by adding proper state validation to prevent OAuth CSRF attacks. The changes replace hardcoded static state values with randomly generated states and add validation in callback handlers.
- Adds a new utility function to generate cryptographically secure random OAuth state values
- Updates OAuth provider interfaces to accept and validate state parameters
- Implements state storage in session and validation during OAuth callbacks
Reviewed Changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| pkg/utils/main.go | Adds GenerateState() function to create random OAuth state values |
| pkg/auth/main.go | Updates Provider interface and implements state generation/validation in OAuth flow |
| pkg/auth/google.go | Updates Google OAuth provider to use dynamic state and validate it during exchange |
| pkg/auth/github.go | Updates GitHub OAuth provider to use dynamic state and validate it during exchange |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Co-authored-by: Copilot <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Implements OAuth CSRF protection by adding proper state validation to prevent OAuth CSRF attacks. This addresses a high-severity security vulnerability where both OAuth providers used hardcoded static state values and lacked state validation in callback handlers.
Type of Change
Related Issues
Fixes #27