Conversation
- Rename environment variable TLS_HOST_AUTO_DETECT to AUTO_TLS - Update CLI flag from --tls-host-auto-detect to --auto-tls - Update function parameter names and error messages - Update documentation in README.md This change improves naming consistency and clarity of the TLS configuration option.
There was a problem hiding this comment.
Pull Request Overview
This PR renames the TLS_HOST_AUTO_DETECT environment variable to AUTO_TLS to improve clarity and align with the project's naming conventions. The change affects variable names, function parameters, and documentation while maintaining the same functionality.
- Renamed
tlsHostAutoDetectparameter toautoTLSin function signatures - Updated environment variable from
TLS_HOST_AUTO_DETECTtoAUTO_TLS - Updated documentation and error messages to reflect the new naming
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| pkg/mcp-proxy/main.go | Updated function parameter name and error message referencing the renamed variable |
| main.go | Renamed variable, function parameter, and CLI flag to use the new naming convention |
| README.md | Updated environment variable documentation to reflect the new AUTO_TLS name |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
| | ---------------------- | -------- | ----------------------------------------------------------------------------------------------------- | ------------------------------------------------ | | ||
| | `LISTEN` | No | Server listen address | `:80` | | ||
| | `TLS_LISTEN` | No | Address to listen on for TLS | `:443` | | ||
| | `AUTO_TLS` | No | Automatically setup TLS certificates from externalURL | `true` | |
There was a problem hiding this comment.
The description for AUTO_TLS should be consistent with the original description. The original was 'Automatically detect TLS host from externalURL' but this shows 'Automatically setup TLS certificates from externalURL'. Consider using the original description for consistency.
| | `AUTO_TLS` | No | Automatically setup TLS certificates from externalURL | `true` | | |
| | `AUTO_TLS` | No | Automatically detect TLS host from externalURL | `true` | |
Summary
Renamed
TLS_HOST_AUTO_DETECTenvironment variable toAUTO_TLSfor better clarity and consistency with the project's naming conventions.Type of Change
Related Issues