fix: trim userinfo to mapped fields before storing in session cookie#141
Merged
hrntknr merged 1 commit intosigbit:mainfrom Apr 13, 2026
Merged
Conversation
The OIDC callback stores the full userinfo response from the provider in a cookie-based session. Providers like Keycloak include roles, groups and other claims regardless of requested scopes, easily exceeding gorilla/securecookie's 4096-byte limit. Derive the needed top-level keys from --header-mapping and --oidc-user-id-field, then strip everything else before saving to the session. This keeps the cookie small while preserving all data needed for header forwarding and JWT claims. Co-Authored-By: Claude Opus 4.6 <[email protected]>
Contributor
Author
|
@hrntknr hello! |
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
hrntknr
approved these changes
Apr 13, 2026
Member
hrntknr
left a comment
There was a problem hiding this comment.
Thank you, this approach seems very appropriate.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
gorilla/securecookie, which has a 4096-byte hard limit. This causessecurecookie: the value is too longerrors for any provider with a non-trivial number of claims.--header-mappingand--oidc-user-id-field, then filters the userinfo map before saving it to the session. When no mapping is configured, the full response is preserved (backwards-compatible).Changes
pkg/auth/auth.go—NewAuthRouteracceptsuserInfoFields []string;filterUserInfo()strips unneeded keys before session storagepkg/mcp-proxy/main.go—userInfoFieldsFromConfig()extracts top-level keys from JSON pointer config flagsTest plan
go test ./...passesfilterUserInfo(specified keys, missing keys, empty/nil input)userInfoFieldsFromConfig(JSON pointers, nested paths, dedup, empty config)🤖 Generated with Claude Code