refactor: centralize ErrAbortHandler recovery in gin middleware#134
Merged
refactor: centralize ErrAbortHandler recovery in gin middleware#134
Conversation
…f per-handler recover Move SSE panic handling from a per-handler recover() in proxy.go and ErrorHandler in transparent.go to a centralized CustomRecoveryWithZap middleware. This provides consistent ErrAbortHandler handling across the entire app without masking legitimate copy errors in the reverse proxy. Relates to #128
Codecov Report❌ Patch coverage is
📢 Thoughts on this report? Let us know! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Move SSE
ErrAbortHandlerpanic handling from a per-handlerrecover()inproxy.goandErrorHandler/isHeadersSentintransparent.goto a centralizedCustomRecoveryWithZapmiddleware inmain.go.The previous approach (#128) suppressed all
ErrAbortHandlerpanics in the proxy handler, which could mask legitimate reverse proxy copy failures (e.g., truncated responses appearing as successful). By handling it at the gin recovery middleware level,ErrAbortHandleris treated the same waynet/httpintended — silently aborting the connection — without interfering with normal error propagation.Type of Change
Related Issues
Follows up on #128