fix(group): fix(group): reject string representations of zero - #1092
Open
daixiheguu wants to merge 1 commit into
Open
fix(group): fix(group): reject string representations of zero#1092daixiheguu wants to merge 1 commit into
daixiheguu wants to merge 1 commit into
Conversation
This PR fixes zero-value validation in `Group.addMember()` and
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes zero-value validation in
Group.addMember()andDescription
This PR fixes zero-value validation in
Group.addMember()andGroup.addMembers().The previous implementation compared the raw
BigNumberinput against0nand"0"before converting it tobigint. As a result, strings such as"00","0x0","-0"and whitespace-padded zero values bypassed the check and were inserted as0n.The inputs are now normalized with
BigInt()before validation and insertion.Batch inputs are fully normalized and validated before the tree is modified.
The
Groupconstructor remains unchanged because it intentionally accepts0nwhen reconstructing groups containing removed leaves.Related Issue(s)
Fixes #1091
Other information
Tests were added for alternative string representations of zero in both
addMember()andaddMembers(). The batch test also verifies that the group is not partially modified when validation fails.Checklist
yarn formatandyarn lintwithout getting any errorsImportant
We do not accept pull requests for minor grammatical fixes (e.g., correcting typos, rewording sentences) or for fixing broken links, unless they significantly improve clarity or functionality. These contributions, while appreciated, are not a priority for merging. If you notice any of these issues, please create a GitHub Issue to report them so they can be properly tracked and addressed.