Skip to content

[codex] Fix clippy node role label iteration#116

Merged
GatewayJ merged 1 commit intorustfs:mainfrom
GatewayJ:fix/clippy-label-keys
May 6, 2026
Merged

[codex] Fix clippy node role label iteration#116
GatewayJ merged 1 commit intorustfs:mainfrom
GatewayJ:fix/clippy-label-keys

Conversation

@GatewayJ
Copy link
Copy Markdown
Member

@GatewayJ GatewayJ commented May 6, 2026

Type of Change

  • New Feature
  • Bug Fix
  • Documentation
  • Performance Improvement
  • Test/CI
  • Refactor
  • Other:

Related Issues

N/A

Summary of Changes

Fixes the clippy iter_kv_map warning reported by CI with Rust/clippy 1.95.

The node role label extraction now iterates over map keys directly with labels.keys() instead of iterating key-value pairs and ignoring the values.

Checklist

  • I have read and followed the CONTRIBUTING.md guidelines
  • Passed make pre-commit (fmt-check + clippy + test + console-lint + console-fmt-check)
  • Added/updated necessary tests (N/A: lint-only code cleanup)
  • Documentation updated (if needed) (N/A)
  • CHANGELOG.md updated under [Unreleased] (if user-visible change) (N/A)
  • CI/CD passed (if applicable)

Impact

  • Breaking change (CRD/API compatibility)
  • Requires doc/config/deployment update
  • Other impact: restores compatibility with newer clippy warnings treated as errors

Verification

make pre-commit

Additional Notes

This follows up on the CI failure observed in PR #115 after GitHub Actions used Rust/clippy 1.95.


Thank you for your contribution! Please ensure your PR follows the community standards (CODE_OF_CONDUCT.md) and sign the CLA if this is your first contribution.

@GatewayJ GatewayJ marked this pull request as ready for review May 6, 2026 15:17
@GatewayJ GatewayJ added this pull request to the merge queue May 6, 2026
Merged via the queue into rustfs:main with commit 335757f May 6, 2026
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant