Skip to content

Simplify downloads#4844

Merged
djc merged 11 commits intomainfrom
simplify-downloads
May 6, 2026
Merged

Simplify downloads#4844
djc merged 11 commits intomainfrom
simplify-downloads

Conversation

@djc
Copy link
Copy Markdown
Contributor

@djc djc commented May 3, 2026

@djc djc requested review from FranciscoTGouveia and rami3l May 3, 2026 20:39
@djc djc force-pushed the simplify-downloads branch from d6eef0e to 823dde3 Compare May 3, 2026 20:40
@rustbot
Copy link
Copy Markdown
Collaborator

rustbot commented May 3, 2026

This PR was rebased onto a different main commit. Here's a range-diff highlighting what actually changed.

Rebasing is a normal part of keeping PRs up to date, so no action is needed—this note is just to help reviewers.

@rami3l rami3l self-assigned this May 3, 2026
@djc djc force-pushed the simplify-downloads branch from 823dde3 to 851139e Compare May 3, 2026 20:55
Comment thread src/cli/self_update.rs Outdated
Comment thread src/dist/download.rs
Comment thread src/download/mod.rs
@djc djc force-pushed the simplify-downloads branch 2 times, most recently from 92a68b8 to cbd4f1e Compare May 3, 2026 21:10
Comment thread src/download/mod.rs Outdated
Comment thread src/download/mod.rs Outdated
@djc djc force-pushed the simplify-downloads branch from cbd4f1e to 5f30344 Compare May 6, 2026 14:20
@djc
Copy link
Copy Markdown
Contributor Author

djc commented May 6, 2026

Dropped the last commit for now, which was a bit too ambitious/too much change at once. Will rework it in a few steps after this is merged.

@rami3l rami3l self-requested a review May 6, 2026 15:59
Copy link
Copy Markdown
Member

@rami3l rami3l left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, let's see how it goes :)

View changes since this review

@djc djc added this pull request to the merge queue May 6, 2026
Merged via the queue into main with commit d51b56c May 6, 2026
29 checks passed
@djc djc deleted the simplify-downloads branch May 6, 2026 19:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants