[IO] Fix potential buffer overflow#22161
[IO] Fix potential buffer overflow#22161bellenot wants to merge 2 commits intoroot-project:masterfrom
Conversation
| // if there is a symbolic link with '.ROOT.cachefile' for safety ;-) | ||
|
|
||
| TString cmd; | ||
| TString cmd(4096); |
There was a problem hiding this comment.
let's use a constant here and line 4413 to clarify that they must stay in sync.
There was a problem hiding this comment.
Actually ... the 'real' size is what ever the result of the 'Form' call is .... how does it relates to the 4096 (is 4096 an upper limit?)
There was a problem hiding this comment.
let's use a constant here and line 4413 to clarify that they must stay in sync.
I agree, but if I use a constant, no need to clarify, it becomes obvious. Let's see...
There was a problem hiding this comment.
Actually ... the 'real' size is what ever the result of the 'Form' call is .... how does it relates to the 4096 (is 4096 an upper limit?)
Ask the author 😉
|
@pcanal so we could simply use: |
Test Results 22 files 22 suites 3d 9h 31m 31s ⏱️ For more details on these failures, see this check. Results for commit 17f66a9. |
2 participants
Fixes https://github.com/root-project/root/security/code-scanning/1846