[6.36][ntuple] Make deserializer fail upon finding feature flags in the footer#22158
Open
silverweed wants to merge 1 commit intoroot-project:v6-36-00-patchesfrom
Open
[6.36][ntuple] Make deserializer fail upon finding feature flags in the footer#22158silverweed wants to merge 1 commit intoroot-project:v6-36-00-patchesfrom
silverweed wants to merge 1 commit intoroot-project:v6-36-00-patchesfrom
Conversation
For compliance with the specs, the serializer should behave the same in the header and the footer in regards to feature flags, and the proper behavior when finding unknown flags is failing. (cherry picked from commit df1474a)
Test Results 17 files 17 suites 2d 10h 26m 26s ⏱️ Results for commit d15df31. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
BP of #22132