Skip to content

ci: notify adp-docs when rpk ai partials change on main - #1852

Merged
JakeSCahill merged 1 commit into
mainfrom
ci/notify-adp-docs-rpk-ai
Jul 31, 2026
Merged

ci: notify adp-docs when rpk ai partials change on main#1852
JakeSCahill merged 1 commit into
mainfrom
ci/notify-adp-docs-rpk-ai

Conversation

@JakeSCahill

@JakeSCahill JakeSCahill commented Jul 30, 2026

Copy link
Copy Markdown
Contributor

Summary

adp-docs publishes the rpk ai reference through single-source stubs of this repo's generated partials (redpanda-data/adp-docs#161). When a merged change adds or removes rpk-ai partials, adp-docs' static stub pages and nav drift: new commands are invisible on the ADP site, and removed commands leave stubs with unresolved includes.

This dispatches sync-rpk-ai-stubs to adp-docs whenever modules/reference/partials/rpk-ai/** changes on main — the moment the partials become real for adp-docs' builds. The receiving workflow redpanda-data/adp-docs#165 runs the doc-tools stub reconciler and opens an adp-docs PR with the stub and nav changes, plus proposed page aliases for likely renames.

Together with docs#1834 this closes the loop Michele described: ADP release → docs partials PR → (merge) → adp-docs stub PR → (merge). The only human steps are the two PR reviews.

Depends on docs-extensions-and-macros#225 (rpk-plugin-stubs command, doc-tools 5.3.0). Recommend merging docs#1849 first so the first reconcile run doesn't resurrect stubs for the two stale partials it removes (verified in a dry run against current main).

Related PRs (rpk docs automation train)

PR Role Depends on
redpanda-data/docs-extensions-and-macros#225 Generator: --plugin mode, change detection, deprecations, What's-new merge, flag extraction, stub reconciler (publishes doc-tools 5.3.0)
#1834 Receiver workflow for plugin-release dispatches #225
#1844 Release workflow: auto What's-new diff base + pre-GA plugin pins #225
#1849 Removes two stale rpk ai partials merge before #1852/adp-docs#165 activate
#1852 Sender: docs main → adp-docs stub sync dispatch #225, adp-docs#165
redpanda-data/adp-docs#165 Receiver: reconciles rpk ai stubs and nav #225, docs#1852
Senders (merged/open) redpanda-data/connect#4636, redpanda-operator#1703 (merged), redpanda-check#10, cloudv2#28552 docs#1834

Merge order: #225 → dependency bumps on docs main and beta → #1834 + #1844 (+ #1849) → #1852 + adp-docs#165 → remaining senders. Jira: DOC-2355, DOC-1090.

adp-docs publishes rpk ai through single-source stubs of this repo's
generated partials. When a merged change adds or removes partials, its
static stub pages and nav drift (invisible commands or broken
includes). Dispatch sync-rpk-ai-stubs so adp-docs reconciles its stubs
automatically.
@netlify

netlify Bot commented Jul 30, 2026

Copy link
Copy Markdown

Deploy Preview for redpanda-docs-preview ready!

Name Link
🔨 Latest commit 480ea7c
🔍 Latest deploy log https://app.netlify.com/projects/redpanda-docs-preview/deploys/6a6b26cca9f8a100079a18d8
😎 Deploy Preview https://deploy-preview-1852--redpanda-docs-preview.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@coderabbitai

coderabbitai Bot commented Jul 30, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

📝 Walkthrough

Walkthrough

Adds a GitHub Actions workflow that runs when rpk ai partial files change on main. It configures AWS credentials through OIDC, retrieves a GitHub Actions bot token from AWS Secrets Manager, and dispatches the sync-rpk-ai-stubs repository event to redpanda-data/adp-docs.

Estimated code review effort: 2 (Simple) | ~10 minutes

Suggested reviewers: feediver1

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Description check ⚠️ Warning The description is detailed, but it doesn't follow the required template and omits the Resolves link, review deadline, page previews, and checks section. Add the template sections and fill in the Jira ticket, review deadline, page previews, and checklist items.
✅ Passed checks (4 passed)
Check name Status Explanation
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Title check ✅ Passed The title is concise and accurately describes the new CI workflow to notify adp-docs when rpk ai partials change on main.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch ci/notify-adp-docs-rpk-ai

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@JakeSCahill

Copy link
Copy Markdown
Contributor Author

@micheleRP when you're reviewing the train, this is the sender half of the adp-docs stub sync (receiver: redpanda-data/adp-docs#165) — it closes the manual stub/nav follow-up from your #161 review. Fires on merges to main that touch the rpk-ai partials.

@micheleRP

Copy link
Copy Markdown
Contributor

No findings. Push-on-main with a path filter is the right trigger, the permissions are minimal, and this is the workflow in the set that gets the token pattern right: fetching the actions bot token from Secrets Manager rather than using secrets.GITHUB_TOKEN. I raised that contrast on #1834 and on redpanda-data/adp-docs#165, where PRs created by the default token do not trigger the repo's own Actions checks.

One ordering note: the receiver in redpanda-data/adp-docs#165 currently produces an unbuildable PR while the two stale rpk ai partials are still on main, so #1849 needs to land before this dispatch can fire usefully. Details are on that PR.

@micheleRP micheleRP left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving. Minimal permissions and the right token pattern. Note the ordering dependency on #1849 in my comment above.

JakeSCahill added a commit that referenced this pull request Jul 31, 2026
…ow-ups at the automated sync

PRs created with secrets.GITHUB_TOKEN do not trigger the repo's own
Actions workflows, so the automated rpk PRs — the largest in the repo —
were the only ones with no run-tests validation (observed on #1845:
Netlify ran, setup and run-tests never did). Fetch the actions bot
token and create PRs with it, matching the senders' pattern.

Also reword the rpk-ai structural-change comment to point at the
automated adp-docs stub sync instead of instructing a manual stub/nav
edit (misleading once #1852 and adp-docs#165 land), and add a job
timeout.
@JakeSCahill
JakeSCahill merged commit 4cd493e into main Jul 31, 2026
7 checks passed
@JakeSCahill
JakeSCahill deleted the ci/notify-adp-docs-rpk-ai branch July 31, 2026 15:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants