Conversation
…ng agents (#405) Composer and steering agents had '*: deny' with no explicit tool allows, causing disabled() to hide ALL tools including read. This made the Composer unable to read source files for task decomposition. Add READONLY_TOOLS constant with read/grep/glob/list/codesearch and restrictive bash patterns (vipune, colgrep, oo help, oo gh issue view/list, oo recall). Both composer and steering agents now use this constant for consistent, safe read-only codebase access.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #405
What changed
READONLY_TOOLSconstant toagent.tswith restrictive read-only permissionscomposeragent to use READONLY_TOOLS (was{ "*": "deny" }with no allows)steeringagent to use READONLY_TOOLS (was{ "*": "deny" }with no allows)Root cause
Both composer and steering agents had "*": "deny" with no explicit tool allows. The
disabled()function correctly hid ALL tools because there were no non-wildcard allow rules to satisfy thehasSpecificAllowcheck. This made the Composer agent unable to read source files for task decomposition, causingtaskctl startto fail.READONLY_TOOLS configuration
Write tools (edit, write, patch) remain denied. Bash access is restricted to safe read-only commands only — dangerous commands like
rm,curl,git pushare denied.Test plan
disabled()disabled()evaluate()returns "allow" for read/grep/glob/list/codesearchevaluate()returns "deny" for bash wildcard "*"evaluate()returns "deny" for edit/write/patch