Skip to content

fix: create_absolute_links() ignores <a> tags without href attribute#2942

Merged
hadley merged 1 commit intomainfrom
b-llm
Oct 28, 2025
Merged

fix: create_absolute_links() ignores <a> tags without href attribute#2942
hadley merged 1 commit intomainfrom
b-llm

Conversation

@krlmlr
Copy link
Copy Markdown
Member

@krlmlr krlmlr commented Oct 28, 2025

Since the introduction of build_llm_docs(), builds for the dm package fail: https://github.com/cynkra/dm/actions/runs/18861352196/job/53820159378#step:18:431 . I have tracked this down to one of the documents containing a tag of the form <a xlink:title="Data Model"> . This PR ignores such tags where it matters.

Run using this package: https://github.com/cynkra/dm/actions/runs/18882666120

@krlmlr krlmlr requested a review from hadley October 28, 2025 16:52
@github-actions
Copy link
Copy Markdown

@krlmlr
Copy link
Copy Markdown
Member Author

krlmlr commented Oct 28, 2025

Weird, tests work locally for me.

@hadley
Copy link
Copy Markdown
Member

hadley commented Oct 28, 2025

Looks like an unrelated quarto issue and your fix is straightforward so I'll merge.

@hadley hadley merged commit 3a19c44 into main Oct 28, 2025
6 of 15 checks passed
@hadley hadley deleted the b-llm branch October 28, 2025 17:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants