Reduced amount of can configuration parameters definition - #113
Merged
Conversation
TiagoLourinho
changed the base branch from
master
to
tl/log-ignored-parameters
September 4, 2026 14:18
TiagoLourinho
force-pushed
the
tl/refactor-duplicated-keys
branch
from
September 4, 2026 14:27
27c3cdc to
9e48479
Compare
luismiguensfernandez
force-pushed
the
tl/refactor-duplicated-keys
branch
from
September 5, 2026 08:00
9e48479 to
37d673b
Compare
added 4 commits
September 7, 2026 08:44
TiagoLourinho
force-pushed
the
tl/refactor-duplicated-keys
branch
from
September 7, 2026 06:44
37d673b to
eb5c1fa
Compare
|
looks good to me |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The list of parameters were being defined in multiple places across the codebase. Now, the python part was changed so it uses the functionality of the
CanDeviceConfiguration::from_map. Then, in the C++ part a unique list of the parameters was created and used across the different needed scenarios.