[backport] use npm: prefix in import map for lodash#13864
Merged
Conversation
* dev: use npm: prefix in import map for lodash as skypack CDN is failing with error 500 * fix: add type annotations for lodash npm: import compatibility The npm: prefix for lodash doesn't preserve generic type inference, causing TypeScript to infer `any` for callback parameters. Added explicit type annotations and type assertions where needed. (cherry picked from commit d341f2a)
Collaborator
✅ Snyk checks have passed. No issues have been found so far.
💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse. |
This avoid failing test while still testing the feature (cherry picked from commit 98a0a0f)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Important
Backport PR #13850
I think we need this for v1.8 dev version to build on CI.
See problem in #13858