Skip to content

html tables - remove trailing spaces in HTML raw block before parsing#12475

Merged
cscheid merged 4 commits intomainfrom
tables/trim-raw-html
Apr 7, 2025
Merged

html tables - remove trailing spaces in HTML raw block before parsing#12475
cscheid merged 4 commits intomainfrom
tables/trim-raw-html

Conversation

@cderv
Copy link
Copy Markdown
Member

@cderv cderv commented Apr 7, 2025

closes #9867

This will prevent creating some HTML RawBlock with only \n as content.

This PR also cleanup leftover file from refactoring done in

cderv added 4 commits April 7, 2025 14:45
This prevent creating a HTML RawBlock with only newlines after the table element
…tables()`

This has been done in #12064

fixup - remove parsehtml.lua
@cderv cderv force-pushed the tables/trim-raw-html branch from 3579d44 to 36cb94d Compare April 7, 2025 13:33
@cderv cderv requested a review from cscheid April 7, 2025 13:53
@cscheid
Copy link
Copy Markdown
Member

cscheid commented Apr 7, 2025

The code change looks good. It's a little less narrow than needed, because this was only breaking pptx. There are a few places where we count elements that might be affected by this change. I think this PR would be fixing bugs in that case (because it's unlikely that we'd want to count these emptyish raw blocks), but I'm mentioning here in case we regress and need to debug.

Copy link
Copy Markdown
Member

@cscheid cscheid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@cscheid cscheid merged commit 428254e into main Apr 7, 2025
49 checks passed
@cscheid cscheid deleted the tables/trim-raw-html branch April 7, 2025 15:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Trim blank line around raw block with table before doing HTML parsing

2 participants