Skip to content

don't loose DOCTYPE header in embed resource processing #12455

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
cscheid merged 3 commits into from
Apr 4, 2025
Merged

don't loose DOCTYPE header in embed resource processing #12455

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
f27ceae
don't loose DOCTYPE header in embed resource processing
cderv Apr 4, 2025
32550ee
Add a regression test for DOCTYPE presence
cderv Apr 4, 2025
caae7f2
don't use Pandoc variable to avoid problem for complex DOCTYPE
cderv Apr 4, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions src/core/pandoc/self-contained.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,11 +48,15 @@ export const pandocIngestSelfContainedContent = async (

// The raw html contents
const contents = Deno.readTextFileSync(file);
const doctypeMatch = contents.match(/^<!DOCTYPE.*?>/);
const dom = await parseHtml(contents);
await bundleModules(dom, workingDir);

const input: string[] = [];
input.push("````````{=html}");
if (doctypeMatch) {
input.push(doctypeMatch[0]);
}
input.push(dom.documentElement!.outerHTML);
input.push("````````");

Expand Down
28 changes: 28 additions & 0 deletions tests/docs/smoke-all/2025/04/04/12295.qmd
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,28 @@
---
title: DOCTYPE is not lost when using embed-resources
embed-resources: true
_quarto:
tests:
html:
ensureHtmlElements:
- []
- []
ensureFileRegexMatches:
- ['\<\!DOCTYPE html\>']
- []
revealjs:
ensureHtmlElements:
- []
- []
ensureFileRegexMatches:
- ['\<\!DOCTYPE html\>']
- []
---

Example from https://github.com/quarto-dev/quarto-cli/issues/12295: Not having DOCTYPE lead to browser using a Quirk mode for CSS, and not applying the standard HTML5.

## Header

```bash
quarto render --help
```
Loading