Skip to content

Convert computational graph diagrams to Mermaid#3872

Closed
saurabhkthakur wants to merge 4 commits intopytorch:mainfrom
saurabhkthakur:fix-requires-grad-diagram
Closed

Convert computational graph diagrams to Mermaid#3872
saurabhkthakur wants to merge 4 commits intopytorch:mainfrom
saurabhkthakur:fix-requires-grad-diagram

Conversation

@saurabhkthakur
Copy link
Copy Markdown
Contributor

Fixes #3580

Description

  • corrected requires_grad value for z in computational graph
  • recreated both computational graph diagrams using Mermaid
    forward computation:
image backward computation: image

Checklist

  • The issue that is being fixed is referred in the description (see above "Fixes #ISSUE_NUMBER")
  • Only one issue is addressed in this pull request
  • Labels from the issue that this PR is fixing are added to this pull request
  • No unnecessary issues are included into this pull request.

@pytorch-bot
Copy link
Copy Markdown

pytorch-bot Bot commented May 6, 2026

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/tutorials/3872

Note: Links to docs will display an error until the docs builds have been completed.

❌ 1 New Failure, 2 Pending

As of commit d58a270 with merge base 08435cc (image):

NEW FAILURE - The following job has failed:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@meta-cla meta-cla Bot added the cla signed label May 6, 2026
@sekyondaMeta
Copy link
Copy Markdown
Contributor

Closing this one in favor of #3873

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Issue: Incorrect requires_grad in the last diagram

2 participants